[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.19] xen/xmalloc: XMEM_POOL_POISON improvements
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 23 Oct 2023 10:28:13 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zTigZYMjAGRm34ngvs6c+HXDkWxj+sXVCwb79DeQjnc=; b=XD+LDLwR+iLKjM88GUzEVuMuTuFSLD0Fgn8LzxdyM7TYchpt2YIZMmpjVCBZL1Uq97QiZJ7nBcXEfFRcNB8ZyACHAbjFb9CkU1Q0NGpibZeSV7US765IWNB+cGnEPS79RRa0vPPB6Omc46oKEjORzM185w0qj3NTuS9eH0yyleXxEob5HCUpBuoJFmDYFTJoKpS0QEarMylBMMlvilqEfqwJU6gGZZ6BuY8Rk3SFNQHK990EkMicqCJ3ztT7FW06xV7I0EytcjPQ/wCpX3EwZAeLa4DSFLys8x3WgsD3J0WLMVQB/RuKkk9FYaAj6UweNFIV78Id+lZ3ULf3qjwZfQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lGF83TwewikAKcYqkcIfZ0gb7PBrX9fQJ5cG/rAV98bRkbn3avkxPJ0aJnCNfS/l9qq3K0xGnDR6XDa12eoygmodV/HgwLA4cOnU8HXx5y9XN0FgQLQRkq5HTIOEY4v6ZJ2sXqk/Lq/m7qqhLy/fiYeXMAKW2aNgUeXVNJkopq0OOi2Pb/boORxN/qGRApqqiwGjCHhAZMZ3jl7ckg36ZEMk/dzJD43EP48YYA8JcG3oPbnTJsxF0XN9CwFjTl19Z7PZwOWKqcIYDnXh6p+EjTdlpjZumOWEDLZ2coMT+HhQX6ZJkGW6aVwGtTnDMoYMMpwK1VJZxdEzyNAtfcqNyA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 23 Oct 2023 08:28:44 +0000
- Ironport-data: A9a23:z8NbI6LEUZCObc6uFE+RHpQlxSXFcZb7ZxGr2PjKsXjdYENS12cCx mBKXGDSPvvZNGrxfNxzPIqxpk0CvJaHydNhSVBlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAhk/nOHvylULKs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrYwP9TlK6q4mhB5gZlPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5SXHEf6 fAmLAxXY1OyiO+8yY6rbuJz05FLwMnDZOvzu1lG5BSBV7MKZMuGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dppTSLpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+tqyjy3bOUwn+rMG4UPIy068Z2mkHQ/0s4DSIbSlq3vtiXlFHrDrqzL GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O/Yh9AiHx67Q4gCYLmsJVDhMbJohrsBebSMu/ k+EmZXuHzMHmL+ITXOQ8J+EoDX0PjIaRUcSaClBQQYb7t3LpIAokgmJXttlCLSyjND+BXf32 T/ikcQlr7AajMpO26Dg+1nC22iovsKRElZz4RjLVGW46A8/fJSie4Gj9Vnc67BHMZqdSV6C+ nMDnqBy8dwzMH1ErwTVKM1lIV1jz6/t3OH06bK3I6Qcyg==
- Ironport-hdrordr: A9a23:ySbfl6oigGxNWTG2KrVz9cgaV5tKLNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN xdmstFeaHN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMD2CAJsQizuRZDzrcHGfE2J9dOAE/d enl7x6T33KQwVmUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyR+49bLgFBCc/xEGFxdC260r/2 TpmxHwovzLiYDw9jbsk0voq7hGktrozdVOQOSKl8guMz3pziq4eYh7XLWGnTYt5MWi8kwjnt Xgqwope+5z93TSVGeopgaF4Xiq7B8er1vZjXOIi3rqpsL0ABo8Fsp6nIpcNj/U8VApst1Q2L 9CmzvxjeseMTrw2ADGo/TYXRBjkUS55VIkjO4olnRaFa8TcqVYo4Az9F5cVL0AACX5woY6F/ QGNrCU2N9mNXehK1zJtGhmx9KhGlw1Axe9W0AH/veY1jBH9UoJuncw9Yg6pDMt5Zg9Q55L66 DvKaJzjoxDSccQcOZUGPoBadHfMB2CfTv8dEapZXj3HqAOPHzA77Tt5q8u2e2scJsUiLMvhZ X6Vk9Cv2JaQTOgNSS35uwKzvnxehT/Ydy0ofsupaSR+4eMCIYDCBfzCWzHyKCb0rAi6s6yYY fABHsZOY6mEYLUI/c54+TPYegsFZAgarxqhj8aYSP7niuZEPycisXrNNDuGZHKLREIHkvCP1 prZkmBGCwH1DHnZkPF
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Oct 23, 2023 at 10:04:21AM +0200, Jan Beulich wrote:
> On 20.10.2023 22:26, Andrew Cooper wrote:
> > However, upping to a BUG() can't provide any helpful message out to the
> > user.
> >
> > I tried modifying BUG() to take an optional message, but xen/bug.h needs
> > untangling substantially before that will work, and I don't have time right
> > now.
>
> I agree with Julien's suggestion of using panic() in the meantime, as a
> possible alternative.
We might care about the stack trace, so would be helpful to print it,
maybe WARN + panic?
> Question though is whether it's better to halt the
> system right away, as opposed to e.g. permitting orderly shutdown to cover
> the case where the corruption ends up not being "deadly".
Hm, won't this be risky, as we could then possibly corrupt data on disk
for example?
Thanks, Roger.
|
