[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.19] xen/xmalloc: XMEM_POOL_POISON improvements
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 23 Oct 2023 10:41:10 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MVd1Mm+Lqy+aVWN4TcF8Mh2zMJ7dKskwVphQLFL5jlI=; b=kUj222LYeQpH9aDyvsbKFGFQ4+r7wKd1Qx4SBqeGVoCHP0PBleOex+MJY38P9zzbwqT9tRYBIL5cidGPqpfvyXivRo7YNOSmiImZJcEOyRMoik/vlnBq2FBZzRRHM/7S81nVyLR6ZzZKoZ/beJXaSx37y6woZAbcxay7u4BVMOQo4JQjdGyRTFvax8Cj8XkZiKZ98ZGNT2TKw+G9r31VWW68cySFUehok7mqNj/KLWwwdcP81kocTRJgx1Vj4usp164IeEr4Yecj132uKIAlVNo1Jrxg5tSi9AopNifuYEVlhs2gxd5GPDVBLxqBNVBXNN0xui3MBraTtfX+CF/stA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gtrz49B1HaDzFdkLqfHMjoApTTLnbSrlLB6Y7VxCzJ5124Or5hfS4Z5HQ+x5srEchttY5Trc4vvu91332jKSmXNGoas4iYZuPaCoC5pYygcApikcsXKzh17pjRln7A6n/mh6PPtMsTrzzbTWhTbmNkyEvkrJpm2xlC7pW2OLX5oAqHkRpEBUba651pL5MDvPkGhh1pF85EPyYB9ESKpWRlppDF6LSUvgGMBfpSbz6G7l9jK4GAIXPn+xJlQY35ddcGwf/ZlGrs1FmC32hC4EFANaFylfyffLSjEMOXTkh2TWyBfsvZcX4vs6+5m6Li1+KtS6Gv6FRrwwSK6me7PfXw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 23 Oct 2023 08:41:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.10.2023 10:28, Roger Pau Monné wrote:
> On Mon, Oct 23, 2023 at 10:04:21AM +0200, Jan Beulich wrote:
>> On 20.10.2023 22:26, Andrew Cooper wrote:
>>> However, upping to a BUG() can't provide any helpful message out to the
>>> user.
>>>
>>> I tried modifying BUG() to take an optional message, but xen/bug.h needs
>>> untangling substantially before that will work, and I don't have time right
>>> now.
>>
>> I agree with Julien's suggestion of using panic() in the meantime, as a
>> possible alternative.
>
> We might care about the stack trace, so would be helpful to print it,
> maybe WARN + panic?
Perhaps, yes.
>> Question though is whether it's better to halt the
>> system right away, as opposed to e.g. permitting orderly shutdown to cover
>> the case where the corruption ends up not being "deadly".
>
> Hm, won't this be risky, as we could then possibly corrupt data on disk
> for example?
It is risky - you never really know which of the two options is better.
Jan
|
