[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 04/29] xen/asm-generic: introduce stub header device.h
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 23 Oct 2023 12:33:02 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gSfOhmZxKkceqUVB+Sr8ey7FNq4+OOxig1hpDrdO9QA=; b=DTrPhb6vIY4q5v9Fend0WWGv0OHZyoUeZGLWhFZbY6yeXZPQYspxbEnjBsE3uASs1Dyib25IsmzQzgIUoASz3qJhoO4PQPNfEaS6rIW3uWMqqPEFJRug5dqRYDBmthLN47JjafLwDx+xo42kc29sdnca73v9T21PefTUokjlP7P/GyNSRkw0jRCnkhzCeDUIOlrSFUqS7Q/Wwolh5w1sNza8D6U0c/ZYmHzQE+0yD8fsUcXY0A4HkQEnR5uavDsE+fJdb6VGBPOVILYRgQzX81fd1z6Lvm+I5SwY7SgzILmJeHMqdsHKX/ZY4qkfDVf/1SS2KlGphhnjihPhXuYmGg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HuAxcVuIIaJFLopb9sfVkKuvuKrrTAhCAGiKzuNK2lzanABd93HmcxKvm7lKGiCpsG2JCUJMtSuIDOYwmlQoshb4t/xpaPYxRsqlqKKmXcJFfJjR0+oAN3FGq+s+Y1OdnABQpmG4gln1NeoyjGE+/U295L5lJ9Q5ARUg/WGunxyDg8AP6CtR1n1EUXjhfgbb6zAwY3kDU3rwCOd5QnHdbws0xHPjXfnQXBZnz/PclY9izr53lIhDXP+e5fTp/2PSmhiCaRnXVWJKJgTBmap1/EOjCKvkDSb3+ndVqfj71vxmP9sNjMcqmyqDAXPRvKpSPzJgky7lruO+M5w3VGcVUw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Julien Grall <julien@xxxxxxx>
- Delivery-date: Mon, 23 Oct 2023 10:33:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.10.2023 12:17, Oleksii wrote:
> On Thu, 2023-10-19 at 13:12 +0100, Julien Grall wrote:
>> Hi,
>>
>> On 19/10/2023 12:41, Jan Beulich wrote:
>>> On 19.10.2023 13:27, Julien Grall wrote:
>>>> that doesn't involve one arch to symlink headers from another
>>>> arch.
>>>
>>> Whether to use symlinks or #include "../../arch/..." or yet
>>> something else is
>>> a matter of mechanics.
>>
>> #include "../../arch/../" is pretty much in the same category. This
>> is
>> simply hiding the fact they could be in asm-generic.
>>
>> Anyway, I have shared my view. Let see what the others thinks.
> I have the same point: if something is shared at least between two
> arch, it should go to ASM-generic.
I continue to disagree: What if one pair of arch-es shares one set
of things, and another shares another set? You can't fit both pairs
then with a single fallback header (unless of course you make it a
big #if / #else / #endif, which I'm inclined to say isn't the goal
with headers put in asm-generic/).
Jan
> And that is the reason why I pushed device.h header to asm-generic.
> It is needed to rename some stuff (e.g... GIC ) in it or add some
> ifdefs.
>
> ~ Oleksii
|
