Re: [PATCH v1 04/29] xen/asm-generic: introduce stub header device.h

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 23/10/2023 11:33, Jan Beulich wrote:
> On 23.10.2023 12:17, Oleksii wrote:
> > On Thu, 2023-10-19 at 13:12 +0100, Julien Grall wrote:
> > > Hi,
> > >
> > > On 19/10/2023 12:41, Jan Beulich wrote:
> > > > On 19.10.2023 13:27, Julien Grall wrote:
> > > > > that doesn't involve one arch to symlink headers from another
> > > > > arch.
> > > > Whether to use symlinks or #include "../../arch/..." or yet
> > > > something else is
> > > > a matter of mechanics.
> > > #include "../../arch/../" is pretty much in the same category. This
> > > is
> > > simply hiding the fact they could be in asm-generic.
> > >
> > > Anyway, I have shared my view. Let see what the others thinks.
> > I have the same point: if something is shared at least between two
> > arch, it should go to ASM-generic.
> I continue to disagree: What if one pair of arch-es shares one set
> of things, and another shares another set? You can't fit both pairs
> then with a single fallback header (unless of course you make it a
> big #if / #else / #endif, which I'm inclined to say isn't the goal
> with headers put in asm-generic/).
TBH, I would expect that if RISC-V and Arm are using the same headers, 
then PPC would likely use it as well. So this would qualify to be in 
asm-generic/.
Now, I don't think we have to resolve the case where we have have two 
arch using one set of headers and the other another sets. We can cross 
that line once we have an example.
Cheers,

--
Julien Grall