[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/pv-shim: fix grant table operations for 32-bit guests
- To: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 23 Oct 2023 13:50:40 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pMu0DOIyqQGn7n1ISvh+0GShf823uiQHyp1kTEWEVww=; b=fN5t+u96rJC8/5Ezr5IrS7zr5p75ng7JnP5E2QV4JBPkfKVqpFtKJTsy3hmN1GVI0U8RQKXxoT/M7kyJwjKKGvX+ycZG5QHMSXDtje/sX1vv7UtCkLb+e/htBDQgnBK+p2SRoEUI6f+TMPvpVr9uAKvI9hhfu6UsooTJjnMS2B+rQYv01HmoYC6aMD5FpMm+GnACRfOM2dNJD+CemAr8zloLTHGSSCpPNPHmXwakSovi4gI5RNe1IcI00qpO49dJIJ0v9wl6Ou8V36XKwBMwdhJuky2Y9lOmECoO21um1OqjYcIrxW+BkRS6R9GXZmgpryKoeg8LWNHeealUW2exXg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L/lv359VsVyCg3aYpuzHqcCKZDJiDKY8CUBVfA5/++5hyQJTraEGxUPr86uazQ4JbMOWqAAtDoGtgk57fFwL7QrK86ejrk5IDY7clWnMVAfsqL4O4UMw6K7evKXcpNpfsvI+kS1EYtv1jQFqErVqut2pfKaIj07rP6ku8t5gkE+9qKXBBihH8vRb72XTKKVBCPXQKncbOi9xq/INl6rGbgqceQHSDQnT5YOymFcGWxMCXj+LghDKjLlfE5G2BZhx5TKTneQ8ZUS4/T0XpPADQDgarK2+qUbNqjLMXky0/4aDKUL0xw2PWOrWa67y2rNxDtmATeUajL+lUFcQSrOfWw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 23 Oct 2023 11:51:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.10.2023 13:34, David Woodhouse wrote:
> From: David Woodhouse <dwmw@xxxxxxxxxxxx>
>
> When switching to call the shim functions from the normal handlers, the
> compat_grant_table_op() function was omitted, leaving it calling the
> real grant table operations. This leaves a 32-bit shim guest failing to
> set up its real grant table with the parent hypervisor.
>
> Fixes: e7db635f4428 ("x86/pv-shim: Don't modify the hypercall table")
> Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
A patch with this same effect has been pending for a long time:
https://lists.xen.org/archives/html/xen-devel/2023-03/msg00041.html (v2;
I have a re-based v3 pending locally, awaiting whatever kind of feedback
on v2). The question of whether it was necessary to split out the actual
bug fix was raised yet earlier, in the context of v1 (albeit I'm not
sure whether that was in email or on irc).
Jan
|
