[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 12/29] xen/asm-generic: introduce stub header pci.h


  • To: Oleksii <oleksii.kurochko@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 23 Oct 2023 13:58:42 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jHgZDqPo3LJGsLBPb2uaLYDJIHn8b/ZjZ36ciO4TMy0=; b=N934jPQL91HeiKFbAHWCzkun/KwxG91vLOvLeju+B0NKtCqN1MQHqg1r9oG7IPdiCwOaihA+k59HnPJG5LC65tKV1ej34e42yHshCeAUInnv3HPzQJIC9+1rfNGtrqLxlDEOysqsGVfEQsJ2xlUFWzNtKBZYakT2phu/4HEeb6QNeqCS4OXWSTwntIT17/jJZesnSmiD71yV21aV5pwQ1N2wvI5jlNm90S+vVBuEj0gc2V+vSGE0vpPrcYRq0q+DI0rdiqtGttdjBIJhUEd/6OwUKCzO2qLY8qIfzI0kLhWa5/uPjBdjysLtSbWYOviPOzqeGCIkALL8PmG57tpK2A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f96BzozM67E3urK2PKfD4Aq95YOv7YVnPkb9pDRk6BmJVL+ZOUAO1gU0LsOqTCZHK+uey3FQ23dwVxByttnzKH62F0I3DLvLKGG0nknEl5ehEffjQ2PLMAITRKS12e1d25lTXaTglKGJyCrMoKyXPZpZMSePXh0mLA/Eo2R6Hohx2CluSqNY5GcgIGsE8neBgcxFNJYPM1WiZXFZh1LrJ67ele/dbfXZL4RcR3LGt7IQRpxrsT25HwxiPhP49ZFBjFX4P25sD5CFCsZaX4/2zLBa7L5A6LOi85bxVZPKpp1UqbZtSqdDslomashu1IXKEgFzObwV5Y+4wpQOnanIBw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 23 Oct 2023 11:58:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23.10.2023 12:50, Oleksii wrote:
> On Thu, 2023-10-19 at 11:55 +0200, Jan Beulich wrote:
>> While more involved, I still wonder whether xen/pci.h could also
>> avoid
>> including asm/pci.h when !HAS_PCI. Of course there's more than just
>> the
>> #include which then would need #ifdef-ing out.
> It looks like we can get with #ifdef-ing. I'll push a separate patch
> for xen/pci.h.
> 
> It will probably need to remove usage of <asm/pci.h> everywhere or
> #ifdef-ing it too.
> Which option will be better?

What's "everywhere" here? The only non-arch-dependent use I can spot
is in xen/pci.h.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.