[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v1 12/29] xen/asm-generic: introduce stub header pci.h
On Mon, 2023-10-23 at 13:58 +0200, Jan Beulich wrote: > On 23.10.2023 12:50, Oleksii wrote: > > On Thu, 2023-10-19 at 11:55 +0200, Jan Beulich wrote: > > > While more involved, I still wonder whether xen/pci.h could also > > > avoid > > > including asm/pci.h when !HAS_PCI. Of course there's more than > > > just > > > the > > > #include which then would need #ifdef-ing out. > > It looks like we can get with #ifdef-ing. I'll push a separate > > patch > > for xen/pci.h. > > > > It will probably need to remove usage of <asm/pci.h> everywhere or > > #ifdef-ing it too. > > Which option will be better? > > What's "everywhere" here? The only non-arch-dependent use I can spot > is in xen/pci.h. It looks you are right. I wrote everywhere because of "xen/drivers/passthrough/vtd/quirks.c" but it is arch-dependent. So , yes, only xen/pci.h should be updated. ~ Oleksii
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |