[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN RFC] xen/automation: add deviations for MISRA C:2012 Rule 8.3
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Federico Serafini <federico.serafini@xxxxxxxxxxx>
- Date: Tue, 24 Oct 2023 17:22:02 +0200
- Cc: consulting@xxxxxxxxxxx, Simone Ballarin <simone.ballarin@xxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 24 Oct 2023 15:22:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24/10/23 16:32, Jan Beulich wrote:
On 24.10.2023 15:22, Federico Serafini wrote:
Update ECLAIR configuration to deviate Rule 8.3 ("All declarations of
an object or function shall use the same names and type qualifiers")
for the following functions:
- set_px_pminfo();
- guest_walk_tables_[0-9]+_levels().
Update file docs/misra/deviations.rst accordingly.
No functional change.
Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
---
I had a discussion with Jan about the reasons behind the choice of parameter
name 'walk' for the definitions of functions guest_walk_tables_[0-9]+_levels()
and the parameter name 'pfec' for the corresponding declarations.
Also for the function set_px_pminfo(), it seems that the parameter names are
different on purpose.
In this latter case I wonder why you think so. Did I end up making a
misleading comment anywhere? It looks to me as if naming the parameter
in question "perf" uniformly would be quite okay.
Jan
No, it was just my impression.
What about the mismatch on the first parameter "acpi_id" vs "cpu"?
--
Federico Serafini, M.Sc.
Software Engineer, BUGSENG (http://bugseng.com)
|
