[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN RFC] xen/automation: add deviations for MISRA C:2012 Rule 8.3


  • To: Federico Serafini <federico.serafini@xxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 24 Oct 2023 18:05:27 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+GoKLKJWy4GhDflO04Brfcph0A3Adg6c6OHB2iNZnu0=; b=dHXMyQ52dGZTuUoNzGh4AACvqoYvBKs+GC4Jtj/K+qRLDw9vV5AZdSqTfCTj1lbytUeBl4NB0dMGqYOO+02/0ZNH/ILXGSsWeoiRzfa6BcgySRLemeaJQqNn/+o6n3vDUobRrsOnG/T+QAKrfeL7d9B449wdfM18VuPFT95ArsOfylw3ADuDjn4gCQN+/JAJ3MC1T0QDwuei8Fm/z0hSTC04S8XfvZoryZtH+b+yL8b5kImWq7+nc/iqx6yTZZTriPoINiPXrQ34/QFMHj7hnI/BTcVYMgcf/u1z4MUveJpumQwSQWF+m2d2TuMHKwrjSiKbLPWRIHmr0ADBS3B10A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GL+ow2ZkEHnD2KD9GzSTJk5zQ1PnlbkdbJ8TdHY6LlXXucEKhC8cYLZWKhzRvw2WaFLjTekEyuYu9UbDEzxdXYgVtHrViXIYuNgajgPCVsnJb7+fR3U/ZVkiYNWZY3JgK9BY95VIcpyvBZIwkKAmg+I81B/rPP2fZCSs2hNawzFp2+uNMTucGIzA1uGrk4llXf4rOqYf7Rcjzy33u4LOjPbde1m5wZTHQzp5Npq5gaoBVpVMpoKpN9QLjXd01w317dmnhWfvKKOtap77B7yfv1n660MpekPlyPqHtKwRk29OpayCsRvFLknAwlFVzydrBeXh8OjO48kQ9gYEEfyjQA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: consulting@xxxxxxxxxxx, Simone Ballarin <simone.ballarin@xxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 24 Oct 2023 16:06:09 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24.10.2023 17:22, Federico Serafini wrote:
> On 24/10/23 16:32, Jan Beulich wrote:
>> On 24.10.2023 15:22, Federico Serafini wrote:
>>> Update ECLAIR configuration to deviate Rule 8.3 ("All declarations of
>>> an object or function shall use the same names and type qualifiers")
>>> for the following functions:
>>> - set_px_pminfo();
>>> - guest_walk_tables_[0-9]+_levels().
>>>
>>> Update file docs/misra/deviations.rst accordingly.
>>> No functional change.
>>>
>>> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
>>> ---
>>> I had a discussion with Jan about the reasons behind the choice of parameter
>>> name 'walk' for the definitions of functions 
>>> guest_walk_tables_[0-9]+_levels()
>>> and the parameter name 'pfec' for the corresponding declarations.
>>> Also for the function set_px_pminfo(), it seems that the parameter names are
>>> different on purpose.
>>
>> In this latter case I wonder why you think so. Did I end up making a
>> misleading comment anywhere? It looks to me as if naming the parameter
>> in question "perf" uniformly would be quite okay.
> 
> No, it was just my impression.
> What about the mismatch on the first parameter "acpi_id" vs "cpu"?

The two can't possibly be used interchangeably, so whichever entity it
is that is being passed should determine the uniformly used name.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.