[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH][for-4.19 v3 1/8] xen/include: add macro LOWEST_BIT
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 26 Oct 2023 08:52:48 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CcaqsFmdUh6Pz6g89a+kS9NqhCSDftwj2y9r0SAFVXg=; b=cMDSCm1YIRhbsYIvMBgQXrdgbUkxWi8ikCGL4apPjb5CNarvj2SAXJV+kWsP/I2VR5JYmShdV3wNZjDX4K40lx5TDxkwitqvsO0lHxo+uao1zh4uZjePTK6juCj4VemejzDg5Cm8gYn9qAkpuGqGeYqc1li6yyC34aIF5zeYYdXqs6fdC6R89HzCBS7WMce5ZfmUR2d1DeAR5owBG6eP4/8oHMY5MEiTLoRe6w0Nyp1YDlasZnBZL+sQUuyMAxxf+9HvVxvAX2iH09lMzlDz/zBEvroBXsflO/6Dyyo0uFyVXo+6DpkqskSox8lnh7FS8dD/4mthszFfqpC9vAe8Jw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IFMrNc0soOdyGZEG3UKln3zHvGlciKQ6PQYopr9vBKzhNEcPf7Oape9IzkmRsKFKL5aOatCSEFn/qN+D24ryOWJ8N1eHbZsVsFiDoSZgxfHvOHU3kyewjoKTfV5V5Uw+czXfzwPHXyPTQOGv528ODW0s51z4tZfjLF4UUcxJrPzsbGQRi8umwgiyUv4/w8A5O5dxprzQUPXmlbKdesmIscmdLJoQiAJ935BhDw/G1Dbg2/Kp6mzPpF4YQly2di5uOeWsouSYW5ERv9s1wGAIP0TGD/8iya3KYyS2ESenb9amMjOVAITlxExOikH2BrYPcmJ0teUWfWuoQceacy0LrA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, Simone Ballarin <simone.ballarin@xxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 26 Oct 2023 06:53:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.10.2023 00:38, Stefano Stabellini wrote:
> On Wed, 25 Oct 2023, Jan Beulich wrote:
>> On 25.10.2023 16:50, Nicola Vetrini wrote:
>>> Ok, I'll send a revised version using MASK_LOWEST_BIT, taking into
>>> account also the
>>> other comments about the explanation on the macro definition
>>> (which some IDEs even show when hovering on its usage, which could
>>> partially address
>>> the latter concern).
>>
>> You're of course free to do so, but since - as indicated before -
>> MASK_LOWEST_BIT() imo isn't a better name than LOWEST_BIT(), I'll
>> continue to object.
>
> Jan if you are OK with that I'll ask Julien to break the tie and pick
> the name to use. Julien can you please help us move forward?
Hmm, I'm having trouble seeing us at the point of breaking ties yet.
First we need naming suggestions which actually unambiguously
describe what's being done by the macro. I gave one suggestion which
I think fulfills this property, but is a little too long for my
taste. I gave another suggestion with a far-off but shorter name,
which I can appreciate isn't liked. I've not seen other suggestions
fulfilling this base criteria.
Jan
|
