[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools/ocaml/Makefile.rules: use correct C flags when compiling OCaml C stubs
- To: Edwin Torok <edwin.torok@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 27 Oct 2023 07:52:35 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5PbzUk38VxIU8334UTiLarqXadgrMhzYyzgwZ8GdFv8=; b=ZIJkKpPxfEaJQUxIitkT0tsiYblBgIDdrh78tW2Z4inCQ2X6C3yWxFLmuXWiAFwScYs3JOiK5YlUYGWwWWl3MBmCQrMWFhPKh7Xk1Q76Bvp18vb60ewx1fAMP4wUjrPJNeoNIcY/uVVZ5OAFp/rBkPAg27b5/BGOHbDAzTqJYH1eHdQScYFngmVXbMeIar/kiLw7Row0eQNiJbQDjXsSlTK6GH6o1ZWkps/GHfcawQeKId2W9qg/YqX2CzCLdgaN4QHuadZAMsmricrnRZuUVelreIQtowZHWepfODumnU16wAzSU0LtB3xl2ipTDh2Tuz6dMCayF9jX8uqlbtGkFw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kJz8Qz7Eljuq9Ii7BOIuOWYe7+wD1+epsy2FLQlxdIOACqtco7q3JRj03lgyjzt0Sbc1cj+Waju3jwGG8biNcQz2P7MHVo1kKJXmB8YQeTABepz20pkeHq2ljTWsmWQikACFKpVA1wWjCD2uH5pNbtUrL7LV5uYVeKilMY5BrCR9oFGM51SPeJ5DrPK0I6MiYAqyfnpGFIYzvHQA52JihwzOKhwWfqsH6kFrmbYIiiLJa1ppV9iLpUkDrUQcG5QRRfHyBrhgCSYznZGdsBbU43dU90Sp31nHlJZ/eNfust8bUm3IBKr3hpdFdgb2+Aznbix1k8SmqYR8EXTB6YSI7Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Edwin Török <edvin.torok@xxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 27 Oct 2023 05:52:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.10.2023 19:38, Edwin Torok wrote:
>> On 25 Oct 2023, at 15:04, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>> On 25.10.2023 15:52, Edwin Török wrote:
>>> --- a/tools/ocaml/Makefile.rules
>>> +++ b/tools/ocaml/Makefile.rules
>>> @@ -37,7 +37,7 @@ ALL_OCAML_OBJS ?= $(OBJS)
>>> $(call quiet-command, $(OCAMLYACC) -q $<,MLYACC,$@)
>>>
>>> %.o: %.c
>>> - $(call quiet-command, $(CC) $(CFLAGS) -c -o $@ $<,CC,$@)
>>> + $(call quiet-command, $(OCAMLOPT) -verbose $(addprefix -ccopt ,$(CFLAGS))
>>> -c -o $@ $<,CC,$@)
>>
>> Wouldn't -verbose better be passed only if the build isn't a quiet one?
>
> Only the OCaml files (and the hypervisor itself) are compiled in quiet mode.
> It looks like tools/ and the C files in tools/ocaml were not,
> so the patch as is preserves the existing behaviour.
Yes and no. There's also make's -s flag, which I consider being wrongly
overridden by passing -verbose here. But anyway ...
Jan
|
