[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 5/5] arm/dom0less: introduce Kconfig for dom0less feature


  • To: Luca Fancellu <luca.fancellu@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Fri, 10 Nov 2023 10:01:57 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wOW6trCc8zTnHRP40ysC1hkMyaXlqA9mm0gd9HxSMNo=; b=e7NXX+fsxT1R7QWTKCeyV7f+Hs0D5d0h7OY/iBqPTAIZudFCOwg7O7xc1c8J0gtSOg7gw5ZRbJLM5d66rP8EbG6iMMJsicb+VyXXTx0LDZ939QQNiIw0iCKbKaO5H/QrXIUMqLAyfQr11Hk/5FTyVAh0Io+VEbUPpI0b1ViRrC0hugwgzDJ5bOB9JCHR5tz5sgBl1okn+brGfkPDFZyP6w5BnnrIIyyNwtIJaVKJtRHT5ptLkrQgd1RI5JGm9qwUj2fv+jOOYk8T3FlH+9ntXxrPw93tWqdBrjH//wxWvB1m1w2r9QsRCgNLrZtX4Fyggt1nmwOP3XpsXGlB/PktcQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tk+7GEV8oNjnSI0CpgJewuKXhNJgolm5u1Ii1aa+/wMdZ3rlNgVfB4+69LJLsDr12BoX7jJRBlYmLRUfpppk82hakZS0tYrJP4W7IyTEDPhQF7adFH36BcnpPcD0HevzwtcbCqY3qCGj8gldHnZ8bSml7EmGoMn9txPEqezJ9g1dmAE0mgxZTJA9Gjvhj+yuxi/BTi+3k0tnxNQ1+afIbh4Gz9c5jUfr0wv8oF37AUjLLBzTLFYHgLNt+khu6S5KC0drvKBawYfoLmanGmFRWXPFBZAoXInjE4fzjxZ501OUQhN3zhg/o60r4NkSzpNtenYgqIl+YU/h8HO+ATJQkg==
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Fri, 10 Nov 2023 09:02:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Luca,

On 09/11/2023 10:06, Luca Fancellu wrote:
> 
> 
> Introduce a Kconfig for the dom0less feature, enabled by default,
> to be able to choose if the feature should be compiled or not.
> 
> Provide static inline stubs when the option is disabled for the
> functions externally visible.
> 
> Use the new Kconfig to remove dom0less DT binding from the efi-boot.h
> code when the Kconfig is not enabled, do the same for
> allocate_bank_memory inside domain_build.c that currently is used
> only by dom0less-build.c module, but it's kept there provisioning
> its usage by dom0 code.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> ---
> Changes from v2:
>  - protect allocate_bank_memory with the new Kconfig
> ---
>  xen/arch/arm/Kconfig                      |  9 +++++++++
>  xen/arch/arm/Makefile                     |  2 +-
>  xen/arch/arm/domain_build.c               |  2 ++
>  xen/arch/arm/efi/efi-boot.h               |  4 ++++
>  xen/arch/arm/include/asm/dom0less-build.h | 12 ++++++++++++
>  xen/arch/arm/include/asm/domain_build.h   |  2 ++
>  6 files changed, 30 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index 0045a3762d86..0399f2faf734 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -88,6 +88,15 @@ config GICV2
>           Driver for the ARM Generic Interrupt Controller v2.
>           If unsure, say Y
> 
> +config DOM0LESS_BOOT
> +       bool "Dom0less boot support" if EXPERT
> +       depends on ARM
You're in the Arm Kconfig, so there should be no need for this dependency (it 
is implicit).

Apart from that, we have 2 features: static mem and static shmem that are only 
meant for dom0less domUs.
Shouldn't we make them dependent on DOM0LESS_BOOT? Otherwise, what is the 
purpose of selecting them
with DOM0LESS_BOOT=n?

~Michal



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.