[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 06/15] xen/asm-generic: ifdef inclusion of <asm/mem_access.h>
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 13 Nov 2023 18:01:04 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gn0uDYeYndmWvOBsGFJ0hLiRdKEfE0AcIsktxhhwJVs=; b=LVkzpm6+gGlLBrDhtnL4HWNHoQYjS13f0nFlYCaeP4exAC6z4xn3x7sk6qkN0QLl3nNq6Hx8hoLxwuBN5GEkaLQm7qJPWehMA6osCOB05VpfbBV4up77p5oWO0o5jin08G8/2rsT+buFAyI6Y6/LUYTf/AyYW78Klm2JsEeC1jkDx/zQe6o7u8z/TrBMmaG/yS2kZ82M2CeAbj4PdhTUNAQGt4+HMVfpBE2kJGTdbbyqu5DeldP6JsjXJR2tKnbKM0lb/PA0JoOqxt6qO0fe0zKUOHcuJ4K1UI2NZNU0Kf+KtxoXKdJRrDyfdWYV3pmgHDxc8Sy6fCCnyCKdGZEQ0g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a+EXigJSA8AtfDkyqX7R9NyhWRDCdux/ikl/9LWMpWFnxCu7E5JxTrlJA6BtzzXYy5dYg+blQoPIA+JSWkVu0ClchPWqbwkpWR03+7SmZ2zY6kyYsHxiyah+RqpDwnmhEQYh9MTH53OPY3htqJbdFnC5xO/hA1+omzgQdIQ9m4XvDN/tb62lKbiJY/VEK0fXIkp51Lchr5h0fvWqgznqKbGfJ+cDGe0glo8otNyEoCaS+vzkjyQT4qazKXuadBvQJhllypXy5Y9q2XAtoPR2GMwu3yv+fDe6PDgYa1XRgbWcJDH3O+gQ/JVsyeHq/jJOOeAr80KdRLdA2O7JepzqOQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 13 Nov 2023 17:01:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11.11.2023 11:24, Oleksii wrote:
> This patch should be reworked as it fails Arm builds:
> https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/1068867920
Took me a while to actually find the error. Would have been nice if you
had explained what's going wrong, supplying the link only as extra info.
> It looks like it is not possible just to #ifdef CONFIG_MEM_ACCESS.
>
> An empty asm-generic mem_access.h will be better solution.
I remain unconvinced. The issue looks to be with p2m_mem_access_check().
One solution would be to move that declaration into the common header.
But there's no common code referencing it, so Arm's and x86's version
might as well diverge at some point. Hence from my pov it again boils
down to Arm's traps.c including asm/mem_access.h explicitly, to bring
the declaration in scope. None of the common files really have a need
to have a dependency on the arch-specific header when MEM_ACCESS=n.
Jan
|
