[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2 06/15] xen/asm-generic: ifdef inclusion of <asm/mem_access.h>
On Mon, 2023-11-13 at 18:01 +0100, Jan Beulich wrote: > On 11.11.2023 11:24, Oleksii wrote: > > This patch should be reworked as it fails Arm builds: > > https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/1068867920 > > Took me a while to actually find the error. Would have been nice if > you > had explained what's going wrong, supplying the link only as extra > info. Sorry about that. I'll be more precise with links next time! But the issue is exactly what you wrote below ( with p2m_mem_access_check and some others from <asm/mem_access.h> ) . > > > It looks like it is not possible just to #ifdef CONFIG_MEM_ACCESS. > > > > An empty asm-generic mem_access.h will be better solution. > > I remain unconvinced. The issue looks to be with > p2m_mem_access_check(). > One solution would be to move that declaration into the common > header. > But there's no common code referencing it, so Arm's and x86's version > might as well diverge at some point. Hence from my pov it again boils > down to Arm's traps.c including asm/mem_access.h explicitly, to bring > the declaration in scope. None of the common files really have a need > to have a dependency on the arch-specific header when MEM_ACCESS=n. I started to do that in that way you mentioned. It should be included in 2 files, at least: p2m.c and traps.c. I am finishind the testing if it is enough. If it is enough, I will send a separate patch. ~ Oleksii
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |