[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Clang-format configuration discussion - pt 1
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 14 Nov 2023 14:59:35 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zoLO2VKz048EC/OL4qJdHfqByj6btyet2Umehb2LgA4=; b=LcAgrwtfKsd5fOfsVVji31gDiLVHwJ+NFYIuBxTVTpwwiR/ufeZptLnijMa6JoXoe6VH0bBKCqa7c1SjA8jazsQity2pZR7oHrTLmjHiTnEHg3AcpWo9qQLq898flXcp1fz61u/+lvbx/+NkmO34cNrNgGaeHhDNAqX38413NsE2EixsRzS1moSOzZfMq7bZPyxzd0oWRFSUnM36QdYG4ic7R+tnxKqp+05CYVH3NXtVYec+uwEEIPQ+pUfc84agW8xkIuLyKYpE24zqQOozqb70OirmiFa/tqCUgSH7f9szzyYka+fCH79YShF54pgQylEYagz6fRxTxUi+qc97Tg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zoLO2VKz048EC/OL4qJdHfqByj6btyet2Umehb2LgA4=; b=CqjpYXvMFfz7o6zRzSEDgznNxQJLIh5BFcpclv7iSPn26iDpgP6lI2ja+VYMrAQeVpl8YluTkjOa21X3qH3X2K1JHT3gE7iiRKyBr0Z3mACiKTIoe6kx4rRAT+KYOoy17XhL1mJrxIPH7FWYcqZEyE7fNkb5XfAmJwfyaZqL/c3iQb3kWJnJ24s9YkErBketCtYq2nZYj+1CPCjDwm56gp+sotlHsOSowXlpEwtS1VKLa2+74E8A1Cy0HkSj1Ii9HxV0tRplJnzoMzIDrHTl74l0QMEc8g32GM9vFG++izP6OXchoW1Tnr9imS5eT0kqJCXCpJiJQ2aY/Kv7K8Wj4Q==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Sn6st5hWoxK6uEkjYWBv3XI40/cM3UouBt4Kyq6Izz8QxAfE/6X1gO5z2UfJ/Arx1YQ9kRZhoRFdsosKCTfJGNHwVY/8qcom/0wsVsToWuBrAWESC3Nfuz22L35EAkQlOxbRHWPMaOuw9nkdtDSInYGCy9IYXgQTjMy2G6Qnfz6G7blqg3kFgl8YWG10thuoIt175UpfZyeP548DJZKNVZ4IEAUqJooqpl5pgZAuzEOcMkAY74Lu3Lxetg2Ar2SHN5dZDaMfUq5el7IbGZH+J1NxGQWR+0mwPNxEMJQBiW12h1ERDrNb/P+h3sLxmQ05ttfNbQQVQZ4FtRTv0/uPrg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JOYEbq5Wk5IQEJ+YgLqvUpvvmgZ2LL33y6PR1cr5EV4uKU6iA+wLxo6qSiYxUINe6AFUsgsEfhFwykzc8Lj2Y1kxTU6lP15Zb7Ztzy5vuZj8E11mCwpZp4xQjPUy++to/Igig3psd/RZh8552FMhBqJDB3z4+8BXw8uIPbu8SGOS54ivgGsAB8mKXKjVk5uoFR4f9AP+cuNPXjMT1Q1R0g9ItbEe0iOn1Dv/9lY4Dyu8ofmAMNrQqPVpQ44rFH6iztq4G5XYf3/W6UXtCT0K09JTNTIKrUDl+Jv1oha/i1m653y3pSpDQVL3sXxjejZhadPLuYQm8mImvYJEzS0p3A==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <Michal.Orzel@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- Delivery-date: Tue, 14 Nov 2023 15:00:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaEild8psuTSSrb0SmQq+9AXKRR7B4JX+AgABAHYCAABLFAIABeZyA
- Thread-topic: Clang-format configuration discussion - pt 1
> On 13 Nov 2023, at 16:27, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 13.11.2023 16:20, Luca Fancellu wrote:
>>> On 13 Nov 2023, at 11:31, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>> On 08.11.2023 10:53, Luca Fancellu wrote:
>>> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>>>>
>>>> Standard: C++03
>>>>
>>>> ---
>>>> From the documentation: Parse and format C++ constructs compatible with
>>>> this standard.
>>>
>>> Since I continue to be puzzled - iirc you said this is because of lack
>>> of availability of "C99" as a value here. What's entirely unclear to
>>> me is: How does this matter to a tool checking coding style (which is
>>> largely about formatting, not any lexical or syntactical aspects)?
>>>
>>>> This value is used also in Linux.
>>>
>>> Considering how different the two styles are, I don't think this is
>>> overly relevant.
>>
>> Ok, maybe I understand your point, you are looking for a reason to declare
>> this configurable instead
>> of not specifying it at all?
>
> Not really, no. Here I was merely saying that with the styles being
> sufficiently different, what Linux uses is probably not very significant
> for our own decision.
>
>> If it’s that, from what I understand clang-format will use the default value
>> if we don’t specify anything
>> for this one, so it will take ‘Latest’. I think we should put a value for
>> this one to fix it and don’t have
>> surprises if that behaviour changes and seeing that also in Linux that value
>> is fixed increased my
>> confidence.
>>
>> However, if you feel that we should not specify it, I’ve done a test and not
>> specifying it is not changing
>> the current output. I can’t say that for a different clang-format version
>> though or if changes happen in the
>> future.
>
> It's fine to set values. All I'm saying is that at least I would prefer
> if it was also clear what exact effect the setting of a value has,
> especially when that does not really match the language we use in the
> project.
Yes I agree, I think Alejandro’s reply to this configurable reflects my
thoughts about it.
So if we all agree that we should set this parameter, do we all agree that it
should be the
value above?
Do you have other concerns regarding this or the other parameters in this
thread?
|
