[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Clang-format configuration discussion - pt 1


  • To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 14 Nov 2023 16:59:35 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JSh2LkanoFnxJw6w+S1nP5flpj8T/jalNiLJWY/HvDc=; b=XpUc96NjzL4FxBtxaCUDQTS2RyReDPGLTBp9khfNSukv28B/s5JAGnkDvJJAzGUED2cYwmezX9EHIcWt6BwNGplqsU4rq/0cmrWVYRoenfsvhnOMxid7WjzgErWey1PbWdD8lwXYwxw6CLidAvURcMIVO/e+GVzhm5cJUz4T1wHIsz3mdmy1+e+VGJIXjb4uArWyEuImGmtT32CJvzc4d5AJ4I3hKEgw2F1f2kOMkt7kk9fw5aGNcvQRRta1P/6tr9oR2h8EU/rdDnNCH5K5h8fjRN1IRtU3FoMd7KlDS+Zmuxe7qB6rKVUXDKPnwSgt8jXdMWNwqqCl5L3EMH/smw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NnDVFJKLa/4br0SvfF4zQGK2IK9e4zWVWe458/PZGrfg+KGNYRfqc3XtaA38qXvMfrjKR1bUDkTxRLyHsaP++3ocL/8hxOrxYorVzA6B8Ane6FJAV/ZaupmdLBZ+WDSK5Yf5VRTefeN3wTzwWYxiUIJc/EmC0cD4l3ykMyP/9JdrbIjjjaxnPT2kXqBOboJjaEKApsYFPOSqfRSUnk2+48p8TjLhmj9XqWequP9luEGIs9PS6I3Jcw1KjSlytjN0jfkXy/JW+Kp70LZbclQ4l7M8bhtIGZYwpoh02TZH/m8+OJr2zEt+hwsajnwKmmWxO+cZer5blNF3jozQbTKp7w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <Michal.Orzel@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
  • Delivery-date: Tue, 14 Nov 2023 16:00:11 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14.11.2023 15:59, Luca Fancellu wrote:
> 
> 
>> On 13 Nov 2023, at 16:27, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>
>> On 13.11.2023 16:20, Luca Fancellu wrote:
>>>> On 13 Nov 2023, at 11:31, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>>> On 08.11.2023 10:53, Luca Fancellu wrote:
>>>> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>>>>>
>>>>> Standard: C++03
>>>>>
>>>>> ---
>>>>> From the documentation: Parse and format C++ constructs compatible with 
>>>>> this standard.
>>>>
>>>> Since I continue to be puzzled - iirc you said this is because of lack
>>>> of availability of "C99" as a value here. What's entirely unclear to
>>>> me is: How does this matter to a tool checking coding style (which is
>>>> largely about formatting, not any lexical or syntactical aspects)?
>>>>
>>>>> This value is used also in Linux.
>>>>
>>>> Considering how different the two styles are, I don't think this is
>>>> overly relevant.
>>>
>>> Ok, maybe I understand your point, you are looking for a reason to declare 
>>> this configurable instead
>>> of not specifying it at all?
>>
>> Not really, no. Here I was merely saying that with the styles being
>> sufficiently different, what Linux uses is probably not very significant
>> for our own decision.
>>
>>> If it’s that, from what I understand clang-format will use the default 
>>> value if we don’t specify anything
>>> for this one, so it will take ‘Latest’. I think we should put a value for 
>>> this one to fix it and don’t have
>>> surprises if that behaviour changes and seeing that also in Linux that 
>>> value is fixed increased my
>>> confidence.
>>>
>>> However, if you feel that we should not specify it, I’ve done a test and 
>>> not specifying it is not changing
>>> the current output. I can’t say that for a different clang-format version 
>>> though or if changes happen in the
>>> future.
>>
>> It's fine to set values. All I'm saying is that at least I would prefer
>> if it was also clear what exact effect the setting of a value has,
>> especially when that does not really match the language we use in the
>> project.
> 
> Yes I agree, I think Alejandro’s reply to this configurable reflects my 
> thoughts about it.
> 
> So if we all agree that we should set this parameter, do we all agree that it 
> should be the
> value above?
> 
> Do you have other concerns regarding this or the other parameters in this 
> thread?

I did raise what was occurring to me. This doesn't mean that down the
road yet something else might not pop up.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.