Re: [PATCH] xenstored: print domain id in traces

[Julien Grall <julien@xxxxxxx>]

Hi Volodymyr,

On 16/11/2023 20:56, Volodymyr Babchuk wrote:
> It is very helpful to see domain id why analyzing xenstored
> traces. Especially when you are trying to understand which exactly
> domain performs an action.
>
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> ---
>   tools/xenstored/core.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c
> index edd07711db..311764eb0c 100644
> --- a/tools/xenstored/core.c
> +++ b/tools/xenstored/core.c
> @@ -135,8 +135,8 @@ static void trace_io(const struct connection *conn,
>         now = time(NULL);
>         tm = localtime(&now);
>   
> -	trace("io: %s %p %04d%02d%02d %02d:%02d:%02d %s (",
> -             out ? "OUT" : "IN", conn,
> +       trace("io: %s %p (d%d) %04d%02d%02d %02d:%02d:%02d %s (",
AFAICT conn->id is an unsigned int. So it should be d%u. This can be 
dealt on commit.
Cheers,

--
Julien Grall