[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xenstored: print domain id in traces
- To: Julien Grall <julien@xxxxxxx>
- From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Date: Mon, 20 Nov 2023 12:28:27 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ii45Co+a2TBdTogtICxoVTXYwN9632ob5OCY7lzGfPA=; b=MZVtM55YiqNP6LWsHIyRnd4qgaZq89r+qlEOgk8v1QUEjglf8/niwpUJnL8Mm6N1xlozDHxkmeGhMMaeQl6W48XRoAOxE1HHD4nBNtsnGt43sl4mMSHpHkoxoPo357umRJD9AmnG1SP/qCA74AW0Gs7256Ls0Cw8tSU2t79TyOwNA2Xh9drXEGyQOeNh4obzt7H0jl5HT/1kvrwQCngphwghK2LOX1Iz6AL7j+mSwLjb1D4ULGC/DB3t4F8Pr8Ecg0/Q9CzvkXAqDyex8cTPjqCTo86LykNkWVrwo+ebLvmjedtCarV88V0vOqPYZVpVCYCizR87YlGXoN4zWQrWZQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fCH5lIdc9tq18M1/S5JoRVc5HuCOraYV0KMPSLuRkI2OKDLbyqYtVub2x5y9oUU7PmB1f/QhJkCDZr9JPGW7q9y6laGOULwcj0c9Vg3zX2/TyHvGunlxc+OC/MNA6Srg+Mq6xGnCzGVBR/ye3jS3MOpF7gDTqEVooryZUiSykAY8jOiGJ2nUmj6YBUCJFSMk4pPNC/E43QT8fahxCTK+XUBAp3J5RNPdlEJBd5PzGDaERgdRkJ2NlsGj9btDZeg/+0/9Qap0HrBRLlbO2RBUnEKUNDsYBRJBzaHOCb1Vl8z8PcdTUwRE17LALUwOuZOtVaeqfUYZecdemejvluT+hw==
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Mon, 20 Nov 2023 12:28:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHaGM9oQiwd7S9EmE2h7a1Tz9yy37B+SeoAgATd0gA=
- Thread-topic: [PATCH] xenstored: print domain id in traces
Hi Julien,
Julien Grall <julien@xxxxxxx> writes:
> Hi Volodymyr,
>
> On 16/11/2023 20:56, Volodymyr Babchuk wrote:
>> It is very helpful to see domain id why analyzing xenstored
>> traces. Especially when you are trying to understand which exactly
>> domain performs an action.
>> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
>> ---
>> tools/xenstored/core.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c
>> index edd07711db..311764eb0c 100644
>> --- a/tools/xenstored/core.c
>> +++ b/tools/xenstored/core.c
>> @@ -135,8 +135,8 @@ static void trace_io(const struct connection *conn,
>> now = time(NULL);
>> tm = localtime(&now);
>> - trace("io: %s %p %04d%02d%02d %02d:%02d:%02d %s (",
>> - out ? "OUT" : "IN", conn,
>> + trace("io: %s %p (d%d) %04d%02d%02d %02d:%02d:%02d %s (",
>
> AFAICT conn->id is an unsigned int. So it should be d%u. This can be
> dealt on commit.
>
Yes, I missed this part. I have noticed that you already committed this
change and even mentioned %u in the commit message. But in the diff [1] I am
seeing %d. Should I sent another another patch that fixes this?
[1]
https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=97f8555acbf3da013ed713ca0bbe739d41c48da9
--
WBR, Volodymyr
|
