[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] x86/treewide: Switch bool_t to bool
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 20 Nov 2023 17:17:14 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1hSFL6wgrPSi4idiKRBHFFLUS3Rg/DmRoAbZINz1eEY=; b=ZlyY3NeaXWCdfqgU1QsqR1AYKjvWb9r/p5w9b/OZZ2nlRWdIp13PK7PhoJEcXy0pfm7S3CrgDUeCp/zXFJqUUeaM4zRVfyGS/t3Gvx0vmpa/t9U2HT6N5mseSK3MEgwb80EkOJYbdmfAO1Cn6T+KGxDt5/l8y4vmWgpUjdYKa7DRy+JkHNQfXhQKmZv3nGoeXbS/zYGO/kOozshF7FEfol0M0vHtGjNsvzxoS3lwfAH0PmjhPWt27GmiLSX0cLEogUXvw71Bm+Z4TDOMq9mcfLtnqr0bmUAi0ye/7TNIGq764awVEK3TNaOF6n73F517RGL62OvBAigewgnvW4baKA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dIezWENnbbADmTHQuKtGmuJouzVRL1cpaDpmJcCR13D9tVxlDJ+ZoByvoYEPGzSe+vLkEvm1Y6dlo14dvZ+gTodg3d9o348I2uU0V+F9nMqgngkT5JB5vY9cOGQbZyr6S5pRGLDw14622v506YerKKwENqTDdDgVRhezN67aQVsBqW2pIdD429dwAkPQ1w29yduBjkeAMPOZcE1jNsWZPf1R/7PYyCYqkSG3M70nr6NKyKQZnbf+02e8tg5u6C/OWQTBbs0VObSa7pLMuvDd9W1bjMj5WXZOTJvkJLBrngkZAcJ/y+i+1cvr4F6RqKNLEIOVgRR/ml/Vtor1fcMZKA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 20 Nov 2023 16:17:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.11.2023 15:56, Andrew Cooper wrote:
> ... as part of cleaning up the types used. Minor style cleanup on some
> altered lines.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
One small request and a nit, though:
> --- a/xen/arch/x86/include/asm/apic.h
> +++ b/xen/arch/x86/include/asm/apic.h
> @@ -139,7 +139,7 @@ static __inline void apic_icr_write(u32 low, u32 dest)
> }
> }
>
> -static __inline bool_t apic_isr_read(u8 vector)
> +static __inline bool apic_isr_read(u8 vector)
Would be nice to also switch to uint8_t at this occasion.
> --- a/xen/arch/x86/include/asm/hvm/io.h
> +++ b/xen/arch/x86/include/asm/hvm/io.h
> @@ -54,7 +54,7 @@ typedef int (*hvm_io_write_t)(const struct hvm_io_handler
> *handler,
> uint64_t addr,
> uint32_t size,
> uint64_t data);
> -typedef bool_t (*hvm_io_accept_t)(const struct hvm_io_handler *handler,
> +typedef bool (*hvm_io_accept_t)(const struct hvm_io_handler *handler,
> const ioreq_t *p);
Nit: Failed to re-indent the 2nd line.
Jan
|
