[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] xen/arm64: head: Move earlyprintk 'hex' string to .rodata.str
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Tue, 21 Nov 2023 18:00:05 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p2DtZCfTxvSpWr0hbq2RadosLP0CREHWT5Q0fDnOS+Y=; b=mY6wSro9n4Hjy6lQkgX6agfHvS+d/OfeUlmW79hrfTB593wCSxIIdZCc/30+1tyUziZBiQBLx4xgF3FfycLslEJp/BBw5YHbn76WELbke1iXzgDc0rjaAagqet/Xb8wRZohVv2qhmQe5ZVcuJONehsCJWs+8bLx3s/XcolgamfowTq/LHn9r97XuWIctWYjQCGbocCGDYqLJcOsu7hVI2/NagWxBXszOFRjhIbrspUYGio1nYI9FeKz3pQHTXtzfRT3tYy4uVCyWBe0bCpcR+bb28f54UOHyM/KEmhhPAo43Y8m3GaytNTu8qaTPS6TMUAbQSNq8ZZgSm/bG2zUbfg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IF1Lmr+dd2DwyTq7lGhRN9aZvLj3EVoLvS3CVUKv7ibpV+4Z95ToAQQcDNbrUpxJ4KeLcIKDxp5AkmMMTfXlZmXj11DyJqAPrNqCwLOn+jzK0S1Q2WzvEqQl34pqqpGNGnXYHBlfLFq4G9Lj/G0ShvD29nSy+wBx7Z6sSm8al8ohobxkJ9TnCyseHs/lA4kHIw431dE6LvuM3TP5PttNa9fmMzwOPozFcQFz2f38Ji54AlJ71K9YdN2P3AMiY28uMwtmGtVU7ogrgNVzbf9T2S+uI3/1ghMkTGoRMjgNZM2lGIbEWKM/Rx12AiDPETXf97xnjku9ianZ+7j+UtiK9A==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 21 Nov 2023 17:00:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Julien,
On 21/11/2023 17:09, Julien Grall wrote:
>
>
> Hi Michal,
>
> On 21/11/2023 09:45, Michal Orzel wrote:
>> At the moment, the 'hex' string is placed right after the 'putn'
>> function in the .text section. This is because of the limited range
>> (+/- 1MB) of PC relative 'adr' instruction 'putn' uses. Modify it to use
>> 'adr_l' instead (range extended to +/- 4GB) and move the string to
>> .rodata.str. This way all the earlyprintk messages will be part of .rodata
>> and the behavior will be consistent with what we already do on arm32.
>
> This will be correct today, but I am actually thinking to move 'hex' to
> .rodata.idmap so it can be used while we are on the 1:1 mapping and/or
> temporary mapping.
So you are planning on extending your series to also cover arm64?
If that is the case, then I'm ok on postponing/dropping this patch.
~Michal
|
