[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] xen/arm64: Move print_reg macro to asm/arm64/macros.h
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Tue, 21 Nov 2023 18:02:03 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hcomW10rOYplO63Jlr9+7f0u0719wmUy6o0yDWVuVQ8=; b=RrX+EEvt6mpTidZw2/1XUfUxCVoXjnwbVkGpYFL26c4PT7ZWQ6TQD+caeZvKlHsUJHsJpdi+zWapRZdBL+caRL0HrLF7Y/GD6bLIuKycxa8FS9UxJqQQNkKGuVR/9wipBSemWWTSP9E2Xo1cn2SzrwTPn0bkeZRt5/P99XQXxrsVNTbp4VGjLnSw10+KwsQgvFhSGaHDAsyQVZaa0rQIJEfhabzoxqNd1ZklNAZUJbwK1I2EvmQocubrE7+tDMX4FYy4p7LYhB0KjyUa8RWdljyRpu7dzl8nXOIL3XANcyCFaEVh8IbMDSatBFDXHKdtb6sR/LfWvo1XIviKvEtyEw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cT2NdHKO63QpDAlwUkMrqymPvcJFSBg0jMsIPUs/48W/OJ/pFjkxaWShJGGzEV5l8gtTPhgoFQdpDMJ8S+50ItAyxLIZGqwlUFNI5eR0TMyOTAzm3mRc3AQ8IaFIAGZpRBnKEDLXIroA8mWRhJfaIgAygROTwZW4UsRbWyx1UCoI3vG7E1AWX2opN4I3bL5JKaSLX8/Jl8kLfDQyM0LmznmkOjS9xwwjU3cgb4QSAtZ8DSEnGmFS3a4mjXGIfX2GvoXXsuqyo+/WgHe5U3ZPGDg/PTe2Z4oYptSnaVIuoxxanLFH5c7mttQ8UApAY6mi0Z4Qty/jzSa6X4nBTktyBg==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 21 Nov 2023 17:02:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Julien,
On 21/11/2023 17:16, Julien Grall wrote:
>
>
> On 21/11/2023 09:45, Michal Orzel wrote:
>> Macro print_reg is used to print a value of a register passed as an
>> argument. While today it is only used from within the common head.S,
>> in the future we might want to make use of it from other files, just
>> like PRINT(). It also serves as a great aid when debugging.
>>
>> Expose print_reg macro by moving it to asm/arm64/macros.h and:
>> - rename putn to asm_putn to denote the usage from assembly only,
>> - use ENTRY() for asm_putn to make it globally visible,
>> - get rid of unneeded stubs for early_puts, init_uart and putn since
>> the calls to them are already protected by #ifdef CONFIG_EARLY_PRINTK.
>
> NIT: The last one read as this is necessary to move print_reg() to
> asm/arm64/macros. But really, this is just a clean-up. So I would add
> something like "Take the opportunity to..." or similar to make it clearer.
Ok, I can do that.
~Michal
|
