[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] x86/treewide: Switch bool_t to bool
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 22 Nov 2023 11:05:39 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FE9fi3BGSx25RwjXXTEVChPHWRpgUYrihs3Qg4Qlac0=; b=I3K4Pjy7upOd+vlJ7Oi6ZYjfjvyCMLSljvRQx37Dwku4b+4NrMkdMA38nYvPFG0IBUdQwtuLwuOLm1JoapqeI7xJ2tm85+CB73+Gv7fQOX0culFCplEXckIe2ctM4wonrwL2PrbRCZio+fDYe7zGAUWzm/dUhsibd14nIPbtHwwL5ctPTXFo5Cp/pYjvQ3+jJ/KH/pTN/KKV/nChVYlsnuEu+LNAgPsH5anHyZiRlrVyPe69vO/UyvVQqh24o1i9YZRPfojruIAXzXl+Ogz129SW3BrtfzgspYuqcJNk174n1FlQBi1FTvpxvGn/XfyVxhj+KNZnJ9IVTmbbBedGVA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fu4yLsyVVPvNpHrwK3r3vAS4eK3VZX5vWu0A6dBlkON9XLDTCCGTwS9jsi2Ne8LsmykmUt1Nl/N0KepqSyVWhGcEriaIei1IhpmvwtY1izOWb24NApXtJYt8+dy+W6I+V9kZ60tRmqOu4+IXBIk3aet0LUXdBMQKrTe3g4W6WsSFaUQPb0r1jRY0bPY17hN+hCUPaseLbDzfb+gKICD6ekvXb+0riohu/OMqsvPGecg7xDgj7zy47aeJZETw/1Js9/n8pD9TSXIRGR3KHVHbwUl4VAPXkx2p7yjnEFsicHs5UKCEOX0Eyy6DSwXTwoqOZtCwn9wj3gJaZzazgcJT/A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 22 Nov 2023 10:05:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.11.2023 15:56, Andrew Cooper wrote:
> @@ -798,11 +799,11 @@ ept_set_entry(struct p2m_domain *p2m, gfn_t gfn_, mfn_t
> mfn,
> unsigned int i, target = order / EPT_TABLE_ORDER;
> unsigned long fn_mask = !mfn_eq(mfn, INVALID_MFN) ? (gfn | mfn_x(mfn)) :
> gfn;
> int ret, rc = 0;
> - bool_t entry_written = 0;
> - bool_t need_modify_vtd_table = 1;
> - bool_t vtd_pte_present = 0;
> + bool entry_written = false;
> + bool need_modify_vtd_table = true;
> + bool vtd_pte_present = false;
> unsigned int iommu_flags = p2m_get_iommu_flags(p2mt, p2ma, mfn);
> - bool_t needs_sync = 1;
> + bool needs_sync = false;
Coverity has just (indirectly) spotted this mistake. I hope no others are
lurking anywhere.
Jan
|
