[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/5] x86/vPIT: check values loaded from state save record


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 22 Nov 2023 11:11:18 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6AfuVueQU6tpmR6J1P/Q38UrAnnQZZVz/Zcx8rFDMHI=; b=bnMCvwdbaOOdfKdVA1fPtHXsg8WU3CD6HPFe8f5Rd13boF2jPNTnkrxVB0DlD7naaXl65ykUY+9/lCValXjknNtnp9a07VDsjCPprDDf44HG3sHJLV244J6xsnxg3LsO6i41riu0DQt8ONId8DOvyJyKU4lV8WXTozBQsLOLEva+NyXG6YrKmtaTSn5vvPqSOlMocOugMr8eSJknROOpWsak1/jry5VbGqI1ltXVoVAfZUch6L79nTq/HucRex3aGgb80cPKJYrvmU2ckRuofeov0ZrWljGKsnhzxDewbx/ls3SzqgUkMZx+TYC5otVHZWNL77HHTvtiXlYuEjVUtA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BUl71msbM4DexiATdhS7d6ZNh+gp+VuC+gzHXVJ96nVCCT2R0oRNQi5xSXBvvySavKfPP1D4dwHxyL/0FIxPWjEdbFHUCVwiJeQWbbaK5m+X/TLRiPrs4+F+LAtPwXh4tZ3CwMp7ikK4ckdbeRxaa/mphcsxltB9bnqCyoF9ROcbEXXuFlVWhvvKDHcSaOoV0syeipwvIhmcedShDR9pulFUBWM3W7YnUjhd/OcTw6kF75dbT1JckwJLTBXLt71lKDo3umzzdDG9cpUnCm23a/En0E8IVD2Jf8lQ2rXHoisQTT14RIQpPZbjcKXLNi79O7B43MOiW2kjAFvGDRQY9Q==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 22 Nov 2023 10:11:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22.11.2023 01:37, Andrew Cooper wrote:
> On 16/11/2023 1:47 pm, Jan Beulich wrote:
>> @@ -427,6 +428,47 @@ static int cf_check pit_save(struct vcpu
>>      return rc;
>>  }
>>  
>> +static int cf_check pit_check(const struct domain *d, hvm_domain_context_t 
>> *h)
>> +{
>> +    const struct hvm_hw_pit *hw;
>> +    unsigned int i;
>> +
>> +    if ( !has_vpit(d) )
>> +        return -ENODEV;
>> +
>> +    hw = hvm_point_entry(PIT, h);
>> +    if ( !hw )
>> +        return -ENODATA;
>> +
>> +    /*
>> +     * Check to-be-loaded values are within valid range, for them to 
>> represent
>> +     * actually reachable state.  Uses of some of the values elsewhere 
>> assume
>> +     * this is the case.  Note that the channels' mode fields aren't 
>> checked;
>> +     * older Xen might save them as 0xff.
> 
> "older Xen" goes stale very quickly.  "Xen prior to 4.19", or "Xen prior
> to the time of writing (Nov 2023)" if you're planning to backport this.

Can certainly adjust. And no, I don't think I intend to backport this.

>> @@ -443,6 +485,14 @@ static int cf_check pit_load(struct doma
>>          goto out;
>>      }
>>      
>> +    for ( i = 0; i < ARRAY_SIZE(pit->hw.channels); ++i )
>> +    {
>> +        struct hvm_hw_pit_channel *ch = &pit->hw.channels[i];
>> +
>> +        if ( (ch->mode &= 7) > 5 )
>> +            ch->mode -= 4;
> 
> How does this work?  If we get in an 0xff, we'll turn it into 0xfb
> rather than 7.

Did you overlook the &= ?

>> @@ -575,7 +625,7 @@ void pit_reset(struct domain *d)
>>      for ( i = 0; i < 3; i++ )
>>      {
>>          s = &pit->hw.channels[i];
>> -        s->mode = 0xff; /* the init mode */
>> +        s->mode = 7; /* the init mode */
> 
> I think it would be helpful to modify the comment to say /* unreachable
> sentinel */ or something.

Can change, sure.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.