[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Clang-format configuration discussion - pt 2
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 24 Nov 2023 13:24:39 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zSxjC4ym79N1JhD4sLaOhJd9vToL+iUqkkHWaWMarBQ=; b=HUTIDxGG2FJD6S4VoqegHfjnmR0KIBh98xQNAYigXCY5Xp4XAmjWHxItP+2UIetwBWEB8aBbcS8n8HB5oBy4ltC1b+Z83pMMh6LTR36MJ4fw1i2ct5oY6daQAUplEhiJKMMlW6Ec56LBEYHyW1PYf5qKytwWyAogla4AjTaGRoZhZonN1CbYP0lUZGfTjMYJGgYZ5xA14LPP8CazOJfYLzb2b7SVuN/wMVxAzIeUJ+VslTRkDR7oXpp8D+usWuNhJ3QN6hnK+O922LoaNSF4rBZi/DFyv/BYdrKEDPzP3tGFcWwukKsBFB6Cd9Q5ZmhqVLJn4hxzMJ9ySxQQPP1k4Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E4WaIXiC0opEe28L5Jo86l0Kcp+hpkesA+JyEPLzkI1v67x152TwhQl9JGfst3Q8dYXSf+HC0Ciywel3Y0AOuSfE0dgBxqqeiCwRRgBzK0Gsvphc+UQ/y236/VJYXQtQRiRagbngnUarvSUneZqDzkmTlfKsONwk2+859LSbmue5uL1qjaf9UX0D55XUARyi2B6o7wcXqrWLhwXMv+2pulndhf853b3/ToOGGxvnQRSQJ6inf8t97bWdoA5ZEBe9H6Ds/PQA2oaSmFlg7iEfNWTldB3N2YBf1y1+v7ImJHvCBLKu0YZwXSY6v8q/XgV/LhG1BqfgQNvuAFX82PlTTA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <Michal.Orzel@xxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxx>
- Delivery-date: Fri, 24 Nov 2023 12:24:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.11.2023 12:59, Luca Fancellu wrote:
> @@ -3333,19 +3318,18 @@ static int __init alloc_domain_evtchn(struct
> dt_device_node *node)
> rc = evtchn_alloc_unbound(&alloc_unbound, domU1_port);
> if ( rc < 0 )
> {
> - printk(XENLOG_ERR
> - "evtchn_alloc_unbound() failure (Error %d) \n", rc);
> + printk(XENLOG_ERR "evtchn_alloc_unbound() failure (Error %d) \n", rc);
> return rc;
> }
> - bind_interdomain.remote_dom = d1->domain_id;
> + bind_interdomain.remote_dom = d1->domain_id;
> bind_interdomain.remote_port = domU1_port;
> rc = evtchn_bind_interdomain(&bind_interdomain, d2, domU2_port);
> if ( rc < 0 )
> {
>
> Assignment of bind_interdomain.remote_dom was aligned with the following
> line, but since the value
> of this configurable is “None”, clang-format is modifying that to use only
> one space before the assignment
> operator.
Neither here nor ...
> One example related to macros can be found on line 1663:
>
> diff --git a/xen/arch/arm/arm32/insn.c b/xen/arch/arm/arm32/insn.c
> index 49953a042a..1635c4b6d1 100644
> --- a/xen/arch/arm/arm32/insn.c
> +++ b/xen/arch/arm/arm32/insn.c
> @@ -19,9 +19,9 @@
> #include <asm/insn.h>
> /* Mask of branch instructions' immediate. */
> -#define BRANCH_INSN_IMM_MASK GENMASK(23, 0)
> +#define BRANCH_INSN_IMM_MASK GENMASK(23, 0)
> /* Shift of branch instructions' immediate. */
> -#define BRANCH_INSN_IMM_SHIFT 0
> +#define BRANCH_INSN_IMM_SHIFT 0
>
> Clang format sees the comment between BRANCH_INSN_IMM_MASK and
> BRANCH_INSN_IMM_SHIFT and
> even if before the value of the macros were aligned, it applies the rule of
> one space between the macro name
> and the value.
... here there is any change in the formatting on the lines in question.
I was first suspecting a possible issue with my mail UI, but
https://lists.xen.org/archives/html/xen-devel/2023-11/msg02132.html
looks to confirm the issue to more likely be on your end (apparently also
resulting in leading whitespace having been dropped).
Jan
|