[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] x86/DMI: adjustments to comply with Misra C:2012 Rule 9.3
On 2023-11-30 11:27, Andrew Cooper wrote: On 30/11/2023 9:47 am, Nicola Vetrini wrote:On 2023-11-30 08:55, Jan Beulich wrote:The rule demands that all array elements be initialized (or dedicatedinitializers be used). Introduce a small set of macros to allow doing so without unduly affecting use sites (in particular in terms of how manyelements .matches[] actually has; right now there's no use ofDMI_MATCH4(), so we could even consider reducing the array size to 3).Note that DMI_MATCH() needs adjustment because of the comma included inits expansion, which - due to being unparenthesized - would otherwise cause macro arguments in the "further replacement" step to be wrong. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> ---Of course a question is how many of these DMI table entries are in factno longer applicable (e.g. because of naming 32-bit-only systems). Subsequently the table in dmi_scan.c itself may want cleaning up as well, yet I guess the question of stale entries is even more relevant there. An alternative to using the compound literal approach might be to go along the lines of #define DMI_MATCH4(m1, m2, m3, m4) .matches = { [0] = m1, [1] = m2, [2] = m3, [3] = m4 }I've chosen the other approach mainly because of being slightly shorter.This looks good. Upon applying this patch I noticed that there's no diffstat, and it doesn't apply cleanly with git-am.So I've had this git alias for more than a decade. $ git help jan-am 'jan-am' is aliased to '!bash -c '(echo -en "From: Jan Beulich <JBeulich@xxxxxxxx>\nSubject: " && cat "$1") | git am' -' However, what you actually want to use these days is https://b4.docs.kernel.org/en/latest/ which integrates with https://lore.kernel.org/xen-devel/ and also does administrative things like collecting acked-by/reviewed-by tags. ~Andrew Thanks, I was able to apply the patch cleanly with this -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |