[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 00/10] Follow-up static shared memory PART I
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Penny Zheng <Penny.Zheng@xxxxxxx>
- Date: Thu, 30 Nov 2023 10:54:20 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xw3WCMG//pYU48orHwkaIfK5wXsX9TwTo3H83JPeCRk=; b=O3xV9knINmMSYvgEjMqOSf/hqQiv8PzQ/2CvCZ2+SaaB1kca/1WBcPu19CIstHuqBwBItP/dIZu+qZs1mSoK1s547r4qn/leeRg1Kz9Vm0cH72ZvRlhtPMW4GqBSwV8NoR0PVXdI6AWROfoG3qdkbxr/Bahd851xhvmwsFBqV6Se9YlO2rX7LpKTTBpeA9WRyebODWOrQ+P5os+qfJbupVHyjQmuab+EVT6qaHWgfBc0qzO01ZpARzbt9E5ZpCAWHNI2lioZWqzCPSOqnaWuajpcygZJVGFWnz8xFK36gWgiLSVEIjSmXqfzfN34Vq4a2UAG2+/6+l8FXqiEByQzHg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xw3WCMG//pYU48orHwkaIfK5wXsX9TwTo3H83JPeCRk=; b=FCJ1IAeCmp4Joc1OaKFIrWhp5f2xiUHO0IpxTIrxYxQnF5/OuycOh9VW1vAlNNOLxJOZs+rjOa0Aw4hLYF88ruuQJT03aE3RFi5044BFTrQEdeDGhwng9TG9YxOHbNQCwcX1YIdmKmv4Nof1b4n5+nstNDVojdZDgxpsu8PL/2B/939kgMUlRIslCgH4sZJpYfF0n/vQ0dez1Xu+TgEUyYe1cbodkT26Nf3FSPhheFonR1PGt1/EjBLsAM9h7pOrGKPy/CEI5zAaTBdgcdspOCxaFn6uHx0SwN41+e/7kHoxQr41oLbxeC1epTvobCmwB8wTAiJ+Z6L/JyEEhEv8CA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=PulTXjmZsRK9P/rUZD1WigcnfMqMtTDLOnU+JN0ic2eXLupFuw6xSfE2X4dvW30hmUXDULYfeAnyfBAOyKv3xukXmHfgfZ7884DtUjGE4PYWe+p7/1THQXer+6kzxrTsaKl95mWBv7YiRJjMDCtUotXSVme3H9t8LoMJI5+8C8wrk7QGMWukrvIItcWqT1DpQD6GNoBsk8KRS98CbOFTotOr9BYVuWa2iNM0bY3rBpN0sewyOpPQ5CfMTsfEHRpJnhuhVD1DhIS1QM71ya78uXPJl5N62GwTtdDm6OdIpPrHDcRrTDI0yZ6Kctcj1uSIdYNZHqSz4l3uvBzv8LSDXA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JMtrCW154c6quiSCNAHs9Dsk/tXvENlHCC1w3ZpyqFI21HhnxNv34VGhvtagE8hBjGLrvg9MS/RLfbBe+oMzk8zr5NO4SFRMNflmAelfJxqBeqNCL43aP5Yr2ar+VYr9iUeBdgJx6YbkafCW0ABdpDNeiyiUF6JtKs5Rrs6T/v9ufySPnUVAseagEFTvvVAXa3DqfsZiqV+zadIpgwubDFXa4Z/HGwhzfTiH+8GOg4vw7AGEa5cpRWybJTeOMp7FypnTgvkecnSSLoT7V7UjSoJlGx+HQoCbWAdtGxODmuny3SuJTNUj6QLpxz2cNOVIULkkZCJo7vlFpkMMuLOgzg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 30 Nov 2023 11:13:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ5GUzsFszTp1+jEGlcEDs/85vrrAVVFeAgAARk4CAfbuvAIAADMEw
- Thread-topic: [PATCH v4 00/10] Follow-up static shared memory PART I
Thanks for the reminder!
I’ll send the updated version ASAP :)
Thanks,
Penny
> 在 2023年11月30日，18:09，Michal Orzel <michal.orzel@xxxxxxx> 写道：
>
> Hi Penny,
>
>> On 11/09/2023 12:04, Penny Zheng wrote:
>>
>>
>> Hi Michal
>>
>>> On 2023/9/11 17:01, Michal Orzel wrote:
>>> Hi Penny,
>>>
>>> On 11/09/2023 06:04, Penny Zheng wrote:
>>>>
>>>>
>>>> There are some unsolving issues on current 4.17 static shared memory
>>>> feature[1], including:
>>>> - In order to avoid keeping growing 'membank', having the shared memory
>>>> info in separate structures is preferred.
>>>> - Missing implementation on having the host address optional in
>>>> "xen,shared-mem" property
>>>> - Removing static shared memory from extended regions
>>>> - Missing reference release on foreign superpage
>>>> - Fix duplicated /reserved-memory node on Dom0
>>>> - Missing static shm node declaration on guest /memory node
>>>> - Missing "xen,offset" feature, which is introduced in Linux DOC[2]
>>>>
>>>> All above objects have been divided into two parts to complete. And this
>>>> patch serie is PART I.
>>>
>>> Just like I pointed out in the previous revision, there is a gitlab CI
>>> failure on shared-memory jobs:
>>> https://gitlab.com/xen-project/patchew/xen/-/pipelines/999098293
>>> Did you change the interface that could lead to this (I cannot spot any
>>> change in the docs refinment) ?
>>> No Xen logs meaning the early boot failure. Please check.
>>>
>>
>> Soooooo sorry. I miss-looked that comment. I found that bug exists in
>> bootfdt.c.
>> ```
>> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
>> index 7d86dffd45..290dd27bf4 100644
>> --- a/xen/arch/arm/bootfdt.c
>> +++ b/xen/arch/arm/bootfdt.c
>> @@ -532,6 +532,8 @@ static int __init process_shm_node(const void *fdt,
>> int node,
>> size, tot_size);
>> return -EINVAL;
>> }
>> +
>> + break;
>> }
>> else if ( paddr_assigned )
>> {
>> ```
>> I accidentally delete a `break;` here, and I will also comment in the
>> related commit and fix in next version!
>>
> While searching for the pending series, I noticed this one.
> If you have time and want us to review the series, please send an updated
> version
> based on the recent Luca's dom0less features modularization.
>
> ~Michal
|
