Re: [XEN PATCH v2 3/3] xen/mm: add declaration for first_valid_mfn

[Julien Grall <julien@xxxxxxx>]

Hi,

On 07/12/2023 11:11, Nicola Vetrini wrote:
> Such declaration is needed to comply with MISRA C Rule 8.4, because a
> compatible declaration is not visible in xen/common/page_alloc.c, where the
> variable is defined. That variable can't yet be static because of the lack of
> support from ARM and PPC for NUMA.
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> ---
> Having this declaration essentially sidesteps the current impossibility
> of having a static variable, as described in the comments in
> ARM and PCC's asm/numa.h.
With this change, is there any reason to keep the various declaration of 
first_valid_mfn in numa.h?
Cheers,

--
Julien Grall