Re: [XEN PATCH v2 3/3] xen/mm: add declaration for first_valid_mfn

[Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>]

On 2023-12-07 14:52, Julien Grall wrote:
> Hi,
>
> On 07/12/2023 11:11, Nicola Vetrini wrote:
> > Such declaration is needed to comply with MISRA C Rule 8.4, because a
> > compatible declaration is not visible in xen/common/page_alloc.c, 
> > where the
> > variable is defined. That variable can't yet be static because of the 
> > lack of
> > support from ARM and PPC for NUMA.
> >
> > No functional change.
> >
> > Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> > ---
> > Having this declaration essentially sidesteps the current 
> > impossibility
> > of having a static variable, as described in the comments in
> > ARM and PCC's asm/numa.h.
> With this change, is there any reason to keep the various declaration 
> of first_valid_mfn in numa.h?
> Cheers,
Good point: no reason comes to mind. I didn't think of it while revising 
the patch.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)