[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/3] xen/arm: Add emulation of Debug Data Transfer Registers
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 20 Dec 2023 09:29:57 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zvV4NR333hxmhIldWvS3gLq5krbNLgCsA1APYtzXxig=; b=cwSpyW2Wu6wWXqJF+lNpyCjyE16UiuOQz4zkbCwRy6z4EPCcnf6f39G9kOpgm+m5s1b0pvS/S0w9Ks+bK4GnWK/911jxlQZLkTZTmhLzvhIgPWD0cQEB5Sky3GghtgYrJVXiKS4ceuZ4ljlaL8WbYkAl/T/459wYtvDeg4o8U12cjcFQXJjEY+W000VoY/Wem/qXX+JelVmFTESGNbLZ3RLnkw51u3a2raFZfcWl8XwbmO3AGE1+HGTQwR41Aos+R1pPvq1qyZZhS3+iVt/tDXD9HlOLlUxtSaVxCv3ZECdvFJ4U1jqMPxWOF7iKKCZ13sfNxVkl2kycuvC21StK6w==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zvV4NR333hxmhIldWvS3gLq5krbNLgCsA1APYtzXxig=; b=EeZyyFypCQiXrDA0QBuU1V5ssCk7VS6WUnts2oW/7N6WLikwC3vf6eYeNA2VTe+Lya7CyMoArCZAYrLbBGsWBsOhaRA5GuEkhEmhiyFJ6ux3ruvi4VdsjKIOgtICiPXpjJrUEsPhxLbZZhSKdfrBIxgD5y3BmHP6TqMhvaOJWp8xFjyVDcBfrhckfZtg1ABRtT4MI44gI9CrbP2DbFo0OCzcmcvoJwBvoqAnubf6hnIfXtuBfuGRpy9LtCH6A4UkYsSzQ49im1qT0+Tv7x0HjMo3m1EJw8FAgxibCiHSM407jLlcjilWRYpjXJFUPcruErPISYHlJV1LlawIewfo2w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RhuKT13MnyVRvlf/61hbiy0WVDSpGRP7os5GSiAMSK2fxZgEE3rpe4RP2aeEt8wiNJ2doxEJ8s/AvkgcFCMYWbZcym+XmkP28q3sQrMKBw8vfOOqQG3YUiqPq839p4av+cWYWSUk+RGO+XK9pz0ZCNRBejr2gNL51UAd8jgpVPljokM8hDVELbXXvn62QILYnGo/LKZVfOs2piCUo/sY+61Njmr/n+ErThzyu98eNbZfmfXvOhMk/M3jjhT840qpXJzG2rLrfIIeeZg5Syxzh0/eXfSkSdR4eshGKCEzae2QY3IEtswtxjt1O/SElJDBhkpiDsbiiFDSL+tDQmFRKA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T+OXxPoYFtEGIzfl0r49pj/hsc5XMNwy7jLAdCMB/v91+Ta9dnLZUHmas4352AlmQlI8N+aBAUQotxwEni8h6H2LvPMF56kNhkWXYnzOHMroqipn9AZ1VcnxS20MnlyTF2/eKnHAvpgFLgtQlSsr3vzDo6pbLSOm+aYx3MUAKOdxVRuDXnm7iO75NZMQRIcRXxAdLZKUiv9d3NgTD5pxUsOz/cX5fBh6ymzCGG952ctfk1xk4L8fsrZ0PAuQtx76bBcVRFQsgSJ2UiqkMCbiClXG/rTCgfvNdEfSYNu9h6I+S334L3M2guOIpK3TMSWHVmJX/sfweM915d2/R7mn9w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, "Volodymyr_Babchuk@xxxxxxxx" <Volodymyr_Babchuk@xxxxxxxx>, "stefano.stabellini@xxxxxxx" <stefano.stabellini@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 20 Dec 2023 09:30:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaMfEa7o9h58xZgUaSJIw5Lcks+LCx6kEA
- Thread-topic: [PATCH v2 0/3] xen/arm: Add emulation of Debug Data Transfer Registers
Hi Ayan,
> On 18 Dec 2023, at 20:29, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx> wrote:
>
> Hi,
>
> Refer
> https://lore.kernel.org/all/alpine.DEB.2.22.394.2312071341540.1265976@ubuntu-linux-20-04-desktop/T/
> for the previous discussion on this issue.
>
> Also, the linux earlycon hvc driver has been fixed.
> See
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/commit/?h=tty-next&id=0ec058ece2f933aed66b76bd5cb9b5e6764853c3
>
> Changes from v1:-
> 1. Split the change across 3 patches as per the design consensus.
>
> Ayan Kumar Halder (3):
> xen/arm: Add emulation of Debug Data Transfer Registers
> xen: arm: Introduce CONFIG_PARTIAL_EMULATION
> xen/arm: Introduce "partial-emulation" xen command line option
I’m a bit puzzled about the order of these changes, wouldn’t be better to
Introduce the partial emulation Kconfig and command line args in the same
patch together with something that uses it?
I think here you wanted to keep Michal patch untouched, but I feel that a
correct split for this serie would be maybe introducing Kconfig, boot args and
one of the arm64/arm32 emulation, and on a second patch the other one
(Or vice-versa)?
If there is something that I’m missing let me know.
>
> docs/misc/xen-command-line.pandoc | 7 +++++
> xen/arch/arm/Kconfig | 8 +++++
> xen/arch/arm/arm64/vsysreg.c | 32 ++++++++++++++++---
> xen/arch/arm/include/asm/arm64/hsr.h | 3 ++
> xen/arch/arm/include/asm/cpregs.h | 2 ++
> xen/arch/arm/include/asm/regs.h | 6 ++++
> xen/arch/arm/include/asm/traps.h | 4 +++
> xen/arch/arm/traps.c | 21 +++++++++++++
> xen/arch/arm/vcpreg.c | 47 +++++++++++++++++++++++-----
> 9 files changed, 117 insertions(+), 13 deletions(-)
>
> --
> 2.25.1
>
>
|
