[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/3] xen/arm: Add emulation of Debug Data Transfer Registers
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 20 Dec 2023 09:43:49 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j1R1e2KVCZufzrdc9uuRCntOMeYjLt63btfagz1c7mA=; b=QSnrphnOZoxYfCsiEzmTUSyTi3ZeAZISiWpo0V7pXB3bz8xB/e+2DCU5I4hfvQ2vAxi14bNG9AeyF4kWKcdCdFfterfQmmF65k17bIORjSxbk84NTaS/f5aXKcCDQna6PGJxd7pFXSrC/juPLTBniri+/xRPJfBIeAFNKwzojba/1SE5/LW/FDm4ZZp+U5vy5mhbsv0J4rIySomUVEVAYAznhj6GmEzKMs/YLtiNsa3WOgdd/LQ5e9fdC+GZQmaNxAXUSEm9DoifbTmJvc7RKe4aKKejH3IHUT0F8wRQqkYOaVEYeGsnU3pPMrmZ8dU5ASZsDKYxz1jKr5vwfcf1+A==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j1R1e2KVCZufzrdc9uuRCntOMeYjLt63btfagz1c7mA=; b=ADKub6jVF/SBZEXmE+c0xi8aotddKJmKtt70B1cgioL81XpinGsOyG2p6KpuD209luownRj2dv9dx0+cYY+U7pSzVV2G0c5luz9WG9cjL0mpfX/kqFFQ8t+3+E2EMR2D/HFoLmYjy86Z2UYK8atxjMX1vYEyxchhC64yp9p89bVzEOuOymXtAQuM2WVrSN0vb2sabLPepT/IjvL3jYyNaDriNfPBi3EK+h4JBet/IiYsf+i0CPO6jq+ulg+romR6jOrFVCodz6p0O9z3E4EzrvfBBYoEMJRaNrL/eMXuQz5LpBP+3VZqKnzkMSiVpMlDnA//LmtxBrPyLpPyPBE4bw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=eIsiqRQyjHxn6VvOmQHv/cMURrYHMCubejA4X+4WvpKltkLlXf1Ckkm88QLAllRnB7jnKJpwj5k4z5ZYMuzu1XnJAc8cECQxgFdjpDusjGtF+4YYDOPNVt3HGCu1gR+mcFzG2WRabXxvbrs/6g0SZ02GLrVIqyXih0gdnGk5iOnw+iVtdJmLGyCDV3DlHDsa/m1KgwRv+lmxGTo6nepiEh7QEG98URJ/TuQvBqJ2HldKrwM/nJk3HSsYKOwKOXnYnrLnem+UBfG1txo5bOqSWGKCMhQ96+a+BODgfHZvXjOQo3kKxZtG6eMCj7bYe4MozP5UmLLpYfIIrKYDR7TFBQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GWhFPLvltNNX6Pomj3dBRa2JIH29n/NjQtd21gt2dKu+5ywj8NwVQHz0tkxKRxHVm9GYpgec2n06NawRJCFS0brFzGc0etG3oumXou4ac3qZ1cOE4H9kzrM0BRpV4xZOHZgJW8GJGR33QoOzTd2E5BI7Rw0OKEaGmPGFIj3YJ3jD//2L3PyyV4f//T3OjfoAzz2SEesnuSzQZxVFD/Uo20qH2VM7WzJhkaABFyzF8TJOTSi+mUdqBQUCqhMbNkK1B+GZLRU/JPY35/g1UNYSjT2RxIBkDCsEFEwKhPhqaANrQLlEqBEqtyqwa82p4CLC71XtWwAVs0hLSktaTUnA8Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, "Volodymyr_Babchuk@xxxxxxxx" <Volodymyr_Babchuk@xxxxxxxx>, "stefano.stabellini@xxxxxxx" <stefano.stabellini@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 20 Dec 2023 09:44:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaMfEa7o9h58xZgUaSJIw5Lcks+LCx6kEAgAAD4AA=
- Thread-topic: [PATCH v2 0/3] xen/arm: Add emulation of Debug Data Transfer Registers
> On 20 Dec 2023, at 09:29, Luca Fancellu <Luca.Fancellu@xxxxxxx> wrote:
>
> Hi Ayan,
>
>> On 18 Dec 2023, at 20:29, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
>> wrote:
>>
>> Hi,
>>
>> Refer
>> https://lore.kernel.org/all/alpine.DEB.2.22.394.2312071341540.1265976@ubuntu-linux-20-04-desktop/T/
>> for the previous discussion on this issue.
>>
>> Also, the linux earlycon hvc driver has been fixed.
>> See
>> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/commit/?h=tty-next&id=0ec058ece2f933aed66b76bd5cb9b5e6764853c3
>>
>> Changes from v1:-
>> 1. Split the change across 3 patches as per the design consensus.
>>
>> Ayan Kumar Halder (3):
>> xen/arm: Add emulation of Debug Data Transfer Registers
>> xen: arm: Introduce CONFIG_PARTIAL_EMULATION
>> xen/arm: Introduce "partial-emulation" xen command line option
>
> I’m a bit puzzled about the order of these changes, wouldn’t be better to
> Introduce the partial emulation Kconfig and command line args in the same
> patch together with something that uses it?
>
> I think here you wanted to keep Michal patch untouched, but I feel that a
> correct split for this serie would be maybe introducing Kconfig, boot args and
> one of the arm64/arm32 emulation, and on a second patch the other one
> (Or vice-versa)?
^^^^^^^-----> for the vice-versa, I meant 1st patch Arm64, 2nd Arm32
or vice-versa.
>
> If there is something that I’m missing let me know.
>
>>
>> docs/misc/xen-command-line.pandoc | 7 +++++
>> xen/arch/arm/Kconfig | 8 +++++
>> xen/arch/arm/arm64/vsysreg.c | 32 ++++++++++++++++---
>> xen/arch/arm/include/asm/arm64/hsr.h | 3 ++
>> xen/arch/arm/include/asm/cpregs.h | 2 ++
>> xen/arch/arm/include/asm/regs.h | 6 ++++
>> xen/arch/arm/include/asm/traps.h | 4 +++
>> xen/arch/arm/traps.c | 21 +++++++++++++
>> xen/arch/arm/vcpreg.c | 47 +++++++++++++++++++++++-----
>> 9 files changed, 117 insertions(+), 13 deletions(-)
>>
>> --
>> 2.25.1
>>
>>
>
|
