[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v11 05/17] vpci: add hooks for PCI device assign/de-assign
- To: Jan Beulich <jbeulich@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Tue, 2 Jan 2024 12:58:29 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dmlAGsq62p60bgTa2od48s76HuFm7BEBMLogG5n7PUE=; b=fq+kE1C5dTs47kLrf4bJQaikLra5j3NrF0RLXXLx4qxc2wbApZ3fdjVmkV4TQm8lSI6hoHCN+Te66He3slWCa86owGFmmLDIE2s1ffSiJYk5vf/J/l1tf0tFaE85+jZ6iJOdVzgcICno3m25WfY4uLzMjjI3I5Gpm8QR7y9yxmN2lEO6FbnCdpqoLma0tE/oCnXJEzCRYLoo7AJ3SAD+mDNaetiXJNB22AUh1aRWF1jsIYW2fEQS1VM5AOPk4wH29MM3oxYlsM70DVGIxCqOD0SdPdW+yOdsdvZ1191k21jat1AYacXL+uEvQQcND6e+0zs0G3/9z6KvlHngD1whVQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fkh9oD5H99+VapfSFPn61xitZ9A+ChQ5SiXqieTnLcUwUK3eCEYbIKxpF287Ps1JOwme/qxDfJJfS8v3lfG6p3cbRmYAknA/toqmmrDnfPB+5AY3XTthkG0STOd0oHBG9we6ihYZfCJbHidJ/vCyM0XIH3FsIAu7lEo506K5BfcGF9LCCgQNoM8AmKcBORph8dY60SqPj3b/pqg7VYOk8vKZjUMy7wTmPoOD6HoXW1DxqsIf0dHdKl6eQq/yyiOmIC+p+gym8EpYtYvQ2ALG43lYuGo8fcZRKomDKchumFNOXn4GIN2d5tF95qYI6/QhkLxBzxewCqFD5UK/Q55z8Q==
- Cc: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 02 Jan 2024 17:58:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12/22/23 03:52, Jan Beulich wrote:
> On 02.12.2023 02:27, Volodymyr Babchuk wrote:
>> @@ -886,6 +890,10 @@ static int deassign_device(struct domain *d, uint16_t
>> seg, uint8_t bus,
>>
>> pdev->fault.count = 0;
>>
>> + write_lock(&target->pci_lock);
>> + ret = vpci_assign_device(pdev);
>> + write_unlock(&target->pci_lock);
>> +
>> out:
>> if ( ret )
>> printk(XENLOG_G_ERR "%pd: deassign (%pp) failed (%d)\n",
>
> Considering the function we're in, I think this "assign" deserves a comment.
OK, we will add a comment along the lines of:
/* Re-assign back to hardware_domain */
> It's necessary for hwdom only aiui, i.e. particularly not for the more
> typical case of putting the device in quarantine?
Right, since dom_io doesn't have vPCI
>
> Jan
|
