[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v11 05/17] vpci: add hooks for PCI device assign/de-assign
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Tue, 2 Jan 2024 12:59:53 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LNv9SfU0t1uskTV7tV/6zk668SUCL/wWCzQAB04Vwo0=; b=NEAn2HGv0897OisgeNLBEM7yj/wl62XEGGDEidHMBSlmH0Uuv5lrED4hOIuEtmil+UnD9cd5vGbPP2b/lDs1Pc5bi7/jK3McvcmW+pgLXKaNxYH6CaFjsC+9491Z5Bx8ZiuDZMR6cb6pH1jjABB8rdo94wOr8RDtxZAfOQ2YGlghZplqSl6qForAcgiWPXvtfIjawKSPUGIt+knUISk8vz0vbo8N7p15iCAy0wL07NsdOKPPzXoBZwb4qJ8/S/0VuOQS2pC++iHSZRjh17pGLevN2vBSGBZ7mpoaGxIWgh6gK4IYPN+lAeLQ3Om2/AqxTcIag5SVDWk2Y47KAwVjFg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yg/ShcVHaU3auk6Py5D5evMVc3RKDdZ1Ud8TYzLzJIDOzWjz0MYilLbWHYmuQ+v1Zrin058jUapwHZWqpLEAJmTrsPBDCBdQakzkH7sg897DngeEo4ukSdOCF3silLjD8gAn1CVsktTicQ1Zsxa9jy+CjpaOaGvIdrvKG1NGtSkgGkmYICNBFA1SZFLN1BrHDbajXmPCfRYgY29LqZF4g/qk1sLP5xPnubIbmjj/qwMZWe/ho+BdMelx2Aw0oKgOGJh2CB4w+Fe5CcBM2DcVtlGi4mwRD2Z24g9Aui+xQWdkGZqDSH5n5xgVgzoebeihGJj7DKBTaCN9kgsLLjkdhQ==
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>
- Delivery-date: Tue, 02 Jan 2024 18:00:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12/21/23 10:21, Roger Pau Monné wrote:
> On Sat, Dec 02, 2023 at 01:27:03AM +0000, Volodymyr Babchuk wrote:
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>
>> When a PCI device gets assigned/de-assigned we need to
>> initialize/de-initialize vPCI state for the device.
>>
>> Also, rename vpci_add_handlers() to vpci_assign_device() and
>> vpci_remove_device() to vpci_deassign_device() to better reflect role
>> of the functions.
>>
>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
>
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks!
>
>> diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
>> index d743d96a10..75cfb532ee 100644
>> --- a/xen/include/xen/vpci.h
>> +++ b/xen/include/xen/vpci.h
>> @@ -25,11 +25,11 @@ typedef int vpci_register_init_t(struct pci_dev *dev);
>> static vpci_register_init_t *const x##_entry \
>> __used_section(".data.vpci." p) = x
>>
>> -/* Add vPCI handlers to device. */
>> -int __must_check vpci_add_handlers(struct pci_dev *pdev);
>> +/* Assign vPCI to device by adding handlers to device. */
>
> Nit: the comment would likely benefit from removing the last device
> before the full stop.
Will fix
>
>> +int __must_check vpci_assign_device(struct pci_dev *pdev);
>
> Thanks, Roger.
|
