[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] x86/xen: Add some null pointer checking to smp.c
- To: Markus Elfring <Markus.Elfring@xxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Jürgen Groß <jgross@xxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, x86@xxxxxxxxxx
- From: Kunwu Chan <chentao@xxxxxxxxxx>
- Date: Mon, 22 Jan 2024 15:43:15 +0800
- Cc: kernel test robot <lkp@xxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, Jean Delvare <jdelvare@xxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>
- Delivery-date: Mon, 22 Jan 2024 07:44:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2024/1/20 22:45, Markus Elfring wrote:
kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure. Ensure the allocation was successful
by checking the pointer validity.
How do you think about to refer to the function name
instead of the file name in the patch subject?
The main goal is to assign a errno to rc. So use 'fail_mem is good to
understand.
…
+++ b/arch/x86/xen/smp.c
…
@@ -114,6 +124,8 @@ int xen_smp_intr_init(unsigned int cpu)
return 0;
+ fail_mem:
+ rc = -ENOMEM;
fail:
xen_smp_intr_free(cpu);
return rc;
Is it currently preferred to start labels in the first text column?
Just the same as the old one. I could fix it if necessary.
Regards,
Markus
--
Thanks,
Kunwu
|
