Re: [PATCH] xen/arm: Properly clean update to init_ttbr and smp_up_cpu

[Julien Grall <julien@xxxxxxx>]

Hi,

On 31/01/2024 07:57, Bertrand Marquis wrote:
> > On 30 Jan 2024, at 18:29, Julien Grall <julien@xxxxxxx> wrote:
> >
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > Recent rework to the secondary boot code modified how init_ttbr and
> > smp_up_cpu are accessed. Rather than directly accessing them, we
> > are using a pointer to them.
> >
> > The helper clean_dcache() is expected to take the variable in parameter
> > and then clean its content. As we now pass a pointer to the variable,
> > we will clean the area storing the address rather than the content itself.
> >
> > Switch to use clean_dcache_va_range() to avoid casting the pointer.
> >
> > Fixes: a5ed59e62c6f ("arm/mmu: Move init_ttbr to a new section .data.idmap")
> > Fixes: 9a5114074b04 ("arm/smpboot: Move smp_up_cpu to a new section .data.idmap)
> >
> > Reported-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Committed. Thanks.

Cheers,

--
Julien Grall