[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] xen: move BUG_ON(), WARN_ON(), ASSERT(), ASSERT_UNREACHABLE() to xen/bug.h
On Thu, 2024-02-08 at 21:30 +0000, Julien Grall wrote: > Hi Oleksii, Hi Julien, > > On 02/02/2024 18:03, Oleksii Kurochko wrote: > > Move the macros mentioned in the commit subject to their > > appropriate > > locations. > > Additionally, eliminate the dependency of xen/lib.h from xen/bug.h > > and > > include "xen/bug.h" in files where xen/bug.h macros are utilized. > > > > Most of the changes were made because a file requires macros from > > xen/bug.h, > > except for some files for Arm which require definitions of > > BUG_OPCODE, > > BUG_INSTR, BUG_FN_REG. > > > > xen/lib.h was added to list-sort.c ( otherwise compilation errors > > related > > to {d}printk occur during compilation of list-sort.c. ) as > > xen/lib.h was > > removed from xen/list.h. Since nothing in xen/list.h depends on > > xen/lib.h > > functionality and only xen/bug.h is needed. > > > > cpufeature.h requires the inclusion of <xen/cache.h>; > > otherwise, the following error will occur: > > ld: > > common/monitor.o:/build/xen/./arch/x86/include/asm/cpufeature.h:41: > > multiple definitions of `__cacheline_aligned'; > > > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx> > > Acked-by: Julien Grall <jgrall@xxxxxxxxxx> Thanks. ~ Oleksii
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |