Re: [XEN PATCH v2] docs/misra: add asm-offset.c to exclude-list

[Julien Grall <julien@xxxxxxx>]

Hi,

Replying on the v2 as well.

On 08/02/2024 15:56, Jan Beulich wrote:
> On 08.02.2024 16:50, Nicola Vetrini wrote:
> > These files contain several deliberate violations of MISRA C rules and
> > they are not linked in the final Xen binary, therefore they can be exempted
> > from MISRA compliance.
I'd like the commit message to be expanded a little bit to explain which 
MISRA rules are a problem. This helped me to understand why we excluded 
rather than fixed.
Base on the previous discussion, I would suggest:

These files contain several deliberate violation of MISRA C rules such as:
  * R20.12 on Arm for macros DEFINE and OFFSET, where the second 
argument of OFFSET is a macro and is used as a normal parameter and a 
stringification operand.
  * R2.1 because the file is not linked That said it was decided to 
deviate the rule itselfed to deviate that aspect).
The files are also not linked in the final Xen binary, therefore they 
can be expempted from MISRA compliance.
> > No functional change.
> >
> > Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> albeit ...
>
> > --- a/docs/misra/exclude-list.json
> > +++ b/docs/misra/exclude-list.json
> > @@ -101,6 +101,10 @@
> >               "rel_path": "arch/x86/efi/check.c",
> >               "comment": "The resulting code is not included in the final Xen 
> > binary, ignore for now"
> >           },
> > +        {
> > +          "rel_path": "arch/*/*/asm-offsets.c",
> > +          "comment": "The resulting code is not included in the final Xen binary, 
> > ignore for now"
> > +        },
> >           {
> >               "rel_path": "common/coverage/*",
> >               "comment": "Files to support gcov, ignore for now"
> ... something looks odd with indentation; can probably be adjusted
> while committing.
I am happy to take care of both the commit message and the indentation 
on commit.
Cheers,

--
Julien Grall