Re: [PATCH v4 02/30] xen/riscv: use some asm-generic headers

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Mon, 2024-02-12 at 16:03 +0100, Jan Beulich wrote:
> On 05.02.2024 16:32, Oleksii Kurochko wrote:
> > Some headers are the same as asm-generic verions of them
> > so use them instead of arch-specific headers.
> 
> Just to mention it (I'll commit this as is, unless asked to do
> otherwise):
> With this description I'd expect those "some headers" to be removed
> by
> this patch. Yet you're not talking about anything that exists;
> instead I
> think you mean "would end up the same". Yet that's precisely what
> asm-generic/ is for. Hence I would have said something along the
> lines of
> "don't need any customization".
Agree that "some headers" isn't the best one option to describe the
changes. Perhaps, it would be better to specify the headers which would
end up the same as asm-generic's version.
Thanks for such notes!

> 
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> > ---
> >  As [PATCH v6 0/9] Introduce generic headers
> >  (
> > https://lore.kernel.org/xen-devel/cover.1703072575.git.oleksii.kurochko@xxxxxxxxx
> > /)
> >  is not stable, the list in asm/Makefile can be changed, but the
> > changes will
> >  be easy.
> 
> Or wait - doesn't this mean the change here can't be committed yet? I
> know the cover letter specifies dependencies, yet I think we need to
> come
> to a point where this large series won't need re-posting again and
> again.
We can't committed it now because asm-generic version of device.h,
which is not commited yet.

We can drop the change " generic-y += device.h ", and commit the
current one patch, but it sill will require to create a new patch for
using of asm-generic/device.h. Or as an option, I can merge "generic-y
+= device.h" into PATCH 29/30 xen/riscv: enable full Xen build.

I don't expect that the of asm-generic headers will changed in
riscv/include/asm/Makefile, but it looks to me that it is better to
wait until asm-generic/device.h will be in staging branch.


If you have better ideas, please share it with me.

~ Oleksii