Re: [PATCH v4 03/30] xen: add support in public/hvm/save.h for PPC and RISC-V

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Mon, 2024-02-12 at 16:05 +0100, Jan Beulich wrote:
> On 05.02.2024 16:32, Oleksii Kurochko wrote:
> > No specific header is needed to include in public/hvm/save.h for
> > PPC and RISC-V for now.
> > 
> > Code related to PPC was changed based on the comment:
> > https://lore.kernel.org/xen-devel/c2f3280e-2208-496b-a0b5-fda1a2076b3a@xxxxxxxxxxxxxxxxxxxxx/
> > 
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Albeit I don't see why ...
> 
> > --- a/xen/include/public/hvm/save.h
> > +++ b/xen/include/public/hvm/save.h
> > @@ -89,8 +89,8 @@ DECLARE_HVM_SAVE_TYPE(END, 0, struct
> > hvm_save_end);
> >  #include "../arch-x86/hvm/save.h"
> >  #elif defined(__arm__) || defined(__aarch64__)
> >  #include "../arch-arm/hvm/save.h"
> > -#elif defined(__powerpc64__)
> > -#include "../arch-ppc.h"
> > +#elif defined(__powerpc64__) || defined(__riscv)
> > +/* no specific header to include */
> >  #else
> 
> ... this isn't simply
> 
> #elif !defined(__powerpc64__) && !defined(__riscv)
I can change that to your option in the next patch version if the patch
won't be merged now.

~ Oleksii
> 
> >  #error "unsupported architecture"
> >  #endif
>