[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 15/22] tools/libs/light: add backend type for 9pfs PV devices



On 13.02.24 19:03, Anthony PERARD wrote:
On Thu, Feb 08, 2024 at 05:55:39PM +0100, Juergen Gross wrote:
+struct libxl__aop9_state {
+    libxl__spawn_state spawn;
+    libxl__ao_device *aodev;
+    libxl_device_p9 p9;
+    uint32_t domid;
+    void (*callback)(libxl__egc *, libxl__aop9_state *, int);

This "callback" is never used, right?

Why do you think so?

In xen9pfsd_spawn() it is used:

  aop9->callback = xen9pfsd_spawn_outcome;


diff --git a/tools/libs/light/libxl_types_internal.idl 
b/tools/libs/light/libxl_types_internal.idl
index e24288f1a5..39da71cef5 100644
--- a/tools/libs/light/libxl_types_internal.idl
+++ b/tools/libs/light/libxl_types_internal.idl
@@ -34,6 +34,7 @@ libxl__device_kind = Enumeration("device_kind", [
      (16, "VINPUT"),
      (17, "VIRTIO_DISK"),
      (18, "VIRTIO"),
+    (19, "XEN_9PFS"),

That's going to need to be rebased ;-).

Yes.


Juergen



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.