Re: [PATCH v5 15/22] tools/libs/light: add backend type for 9pfs PV devices

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Wed, Feb 14, 2024 at 11:18:18AM +0100, Jürgen Groß wrote:
> On 13.02.24 19:03, Anthony PERARD wrote:
> > On Thu, Feb 08, 2024 at 05:55:39PM +0100, Juergen Gross wrote:
> > > +struct libxl__aop9_state {
> > > +    libxl__spawn_state spawn;
> > > +    libxl__ao_device *aodev;
> > > +    libxl_device_p9 p9;
> > > +    uint32_t domid;
> > > +    void (*callback)(libxl__egc *, libxl__aop9_state *, int);
> > 
> > This "callback" is never used, right?
> 
> Why do you think so?
> 
> In xen9pfsd_spawn() it is used:
> 
>   aop9->callback = xen9pfsd_spawn_outcome;

By never used, I mean that nothing is reading the value, their is no
"aop9->callback(egc, aop9, rc)" call.
It might have been useful if a caller of xen9pfsd_spawn() was actually
setting this field, but that's not an option here. And callbacks of
xen9pfsd_spawn() knows to call xen9pfsd_spawn_outcome() when done.

Cheers,

-- 
Anthony PERARD