[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/11] xen/arm: Conditional compilation of kernel_info.shm_mem member
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 4 Apr 2024 09:27:47 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y2Fg51ZUFHtjpVEZiwGUv3H9M1YsNRXkjRQoAZBiqzM=; b=nlFWAc+Rj6jaahU3Ro4TzfAbZg23EGI1wrsa7U7+heXjNSe20aA2gq29GJoR3AM0NEJpSyG5xqLe87KgWUJI2DzOmz41ZKe12iHGDENHviB0QF76F6QJ/L1wR+H8LutYBnziMflLH4m9YDs0j/uzA5hj6GXSrwy2uaVwf6R7+N6yN37PVyA/mYMDwRi94fvt5H6yTOr2Xv9hpJRlwaeyQQACw/fvUchTmRMBJmnOCz0J9+b3C0jgqsmKHimnSSHx9/cOzfGb6ZVn5EzhJ5EZasz/LZH11SQ8LvRAdYbpEBeJwFI4QhV0MmvevkGaqj7ODa62FnZ2rUqBYFSaUUL1Vg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y2Fg51ZUFHtjpVEZiwGUv3H9M1YsNRXkjRQoAZBiqzM=; b=jTJtkppJ9ymIC+KpkLFOOlvCV0FPBJyS1tesoz3e8VS9kDhscLcJRfykp4RLb6vqmidAjnuOEzx6G6KVEZgMmPuxF6x/6nlUi0IgroagXRzxKKEjEUYLKkZTGIlSWu0Y5eRhDbWGlH/PioYNBxZr6agHcStzBBg9xgcjMpCWwoP71LEo+ZXwksr/gtZ64jhDotq794uzd8SKXvpdSwSB5LZrSWSgvUajmTYWXhfllIuE2ealIK/IV8blDn/6iQx/IBg47aVuYjMuN4EsUoxmgjZvt+kCLkOEhTAXmYC3hoXnQhEY1qb2ZOPw/TgFCISzcBLLv4zM0hgt1HcQJ0ZzcA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=S5eUbsYK92cyMkxqtwNK3S0VIH4uphY5PWjqeBVFUXlb73ezGipe40G0Ni2RPbTxNgky27QAoY08o78cuCjVJwM/xQTKvqmGVuoDEj4l971NR1DPIcS3sOmp8zXZkw5aBzpuRCpUJADR1uOqUPpAjBaP8G99hj18NO5H+JVT8THTlnZXis4T78jLyWf509/EdbuDkQgvYUSKBolYT1gPAnQ/2b5ilRVR8vx3lh/5YFzJxCuoWHreiaNXJ4OoDCJwbhEjhnNDdGymd2ofLy1fI1H0oqRV/Ahv9usH77LAGrQzmh13dV8Hm62ImbR1c49+j3rfUs4sUAKAd+90YSz0ag==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fV/WrgmfoM0n/LRe1BhTF2TKMhA7V9Rx6N3Q3VuqgavU+sRLHpwoSSitQr1Q5RI6GoH1CbRfvbF0S7o108huSwCN7MxPqLXGK9PPqrgx0Ky8KByFXN1S1s668Deka6Jri7s0Rs14FUJKXHmERZw505uhQNT6L9NCU4uh9lvuFUt9K7vfAIkKUfI/3hYBuDzuLK17w+QT4JFYy/6n27vemMSL3u9DSOIFCs+5juahEKscfpBi89n5JI87JBax7uaswgP1LR38lROny43C6OxkW4LrGBNa0GBp06jLwXYO/dlXv/rMItr32Sk2jTaFyBduZLYGevwnowKGYJw2Zh0ZAA==
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 04 Apr 2024 09:28:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHadH3RHiV9l/CStk23F/JZ/hhrzLE/Mq8AgBjI/4A=
- Thread-topic: [PATCH 04/11] xen/arm: Conditional compilation of kernel_info.shm_mem member
> On 19 Mar 2024, at 14:58, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> Hi Luca,
>
> On 12/03/2024 14:03, Luca Fancellu wrote:
>>
>>
>> The user of shm_mem member of the 'struct kernel_info' is only
>> the code managing the static shared memory feature, which can be
>> compiled out using CONFIG_STATIC_SHM, so in case the feature is
>> not requested, that member won't be used and will waste memory
>> space.
>>
>> To address this issue, protect the member with the Kconfig parameter
>> and modify the signature of the only function using it to remove
>> any reference to the member from outside the static-shmem module.
>>
>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> NIT: I always wonder why we have hundreds of functions taking both struct
> domain and
> struct kernel_info as arguments if the latter has the former as its member.
> As you are
> revisiting the function and modifying parameter list, you could take the
> opportunity
> to change it. But you don't have to.
You are right, can I do this modification as part of patch 3 and this one?
Also, can I keep your R-by
here when doing this change?
>
> ~Michal
>
|
