[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/11] xen/arm: Conditional compilation of kernel_info.shm_mem member
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Thu, 4 Apr 2024 11:33:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z7XVk3eXm6kIotJRQSDjHuPdgRvu9LQVIsHzosGwGUs=; b=cKmS9+jYcsW9Rruo2AFMI75aAf8rX0GfmlryIBmC2TrBiMI9TccIQ66aCv8zEYzdlhhuZG0Yk7cGYl10BxzxtyKckJYfQvezzAIZP2Ps3U2uw1zXXmTQpRlhz7CGmFoTzNrvOqo+tB1Zer5OHqK/8nD5xKaNacPZOc9j4Ifgjx6n2dqMphmOS7ZtjUXbrozxOHvEpxm5YAIcVOyKMOvdbqSoW/+apd2fUPPpm3GFBLn1O3eQ0uHzDgC0RtdSQNz2YA7rvL5dpNaGghG+2lMoI/dyCc1238jrFkcAZUlsrIdvO4CQ4zZZdV8ni6P02eVXlWXPhTifmsyJyL20wKOkyw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fSUqWUXTzCT+/j72IWesg9d1H3qPe+Xjpk2zOi+fbGD20dbiGrQAawqNa7wNTAadvS0AkFskCyUCHaiz5h5fkZ/h9Z6NqdkTALeewi6kzTqhjW12glr2H+QndarTh+kd6wjTtO/QDzaMqvpXmafPeMTjLXcuNZe4OED9N3E5C+anuITpDyaNfQimO2m9XpjqioKCgevcJLlgnEMpurmYCPWn0U0yTX5GeEig3DnoCrQLA+w1KfnLBcxY36Vl3LCfto+rima2uvWpUq82fqeh0HBoNBC8KhLCcsYBtx5bMAni1y9SEvnfOtFey2TkEa02Mq8p35btDtngfbisAUqKnA==
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 04 Apr 2024 09:33:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Luca,
On 04/04/2024 11:27, Luca Fancellu wrote:
>
>
>> On 19 Mar 2024, at 14:58, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>>
>> Hi Luca,
>>
>> On 12/03/2024 14:03, Luca Fancellu wrote:
>>>
>>>
>>> The user of shm_mem member of the 'struct kernel_info' is only
>>> the code managing the static shared memory feature, which can be
>>> compiled out using CONFIG_STATIC_SHM, so in case the feature is
>>> not requested, that member won't be used and will waste memory
>>> space.
>>>
>>> To address this issue, protect the member with the Kconfig parameter
>>> and modify the signature of the only function using it to remove
>>> any reference to the member from outside the static-shmem module.
>>>
>>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>>
>> NIT: I always wonder why we have hundreds of functions taking both struct
>> domain and
>> struct kernel_info as arguments if the latter has the former as its member.
>> As you are
>> revisiting the function and modifying parameter list, you could take the
>> opportunity
>> to change it. But you don't have to.
>
> You are right, can I do this modification as part of patch 3 and this one?
> Also, can I keep your R-by
> here when doing this change?
You can do this as part of patch 3 (afaict there will be no need to modify the
argument list in patch 4)
and you can keep my Rb.
~Michal
|
