[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/4] docs: add xen_ulong_t to the documented integers sizes/alignments
- To: Julien Grall <julien.grall.oss@xxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 12 Apr 2024 15:30:35 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yJmK3wVdKY1cpzBM1fyWzpOP5nOKjRVG/PS/RQthayk=; b=nMNKy0l1DaZQD8ayFQwv1l7Zyq1HSCGDRW6hjoFmFC3a8xyElIShO+55ldINbGB3YBaVOLQpfJpOHbKBa0y7spVMwnT/8Da3OivBHqJRQBi3Tphh/o73LLJeMFhNMh+tUq5PiWhCVckT5s9oN6dAkxzNeh+vUFi6Q0+Tf8lNdl196Dy6+KYVONtBDjUf4j9vHCMYrvsex5zOZsSMmocuf69tsluwfoqrQa0PV1t0oJoA83COFXdb19cMet4Usk4GyyCjbiuTpgIvSdgs03O5ttV5jo4NGKPzKKq5G+cUqOfcfbcgmktSRnE6RTXOD+6mOLBfW/G0eIC/wQEnJ5AjHw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yJmK3wVdKY1cpzBM1fyWzpOP5nOKjRVG/PS/RQthayk=; b=CgUjhKBcOvxq0vc7dLy2mC1l8mf6iNhkewU8WfGAswie5HqAP86mDxp/GxcQwN3Ph3mtR86Sni0YM+ncmm+whpvBdl7ijPDkaSl2kR9PTnAUzNqjP4Zug7z9gZEGHwsntnOcatftZuZ/konWiTe5QJnVPyd3zWnz6onqlHVpGsOZCuQhcjAmWZnDJfWDtYI/t7we2ZrSU6ahBrtciSDTrPQ9ZxMXCccfH/1RoC6PDgu6chMSn9UBDd0eT3hpkcfsc5A+0Ro4JfSwlK0O+DPM+BUJInE2tatlof4hrOKZrehGbKpwa8+/c8f3gfWZQV6DZa+5EOyvHC5e0UazBssIEA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cLQho5YYD2A4NNU2S2CBI6+o8dY+Jc2ZRgoJLJBZKCut0va+1ioz8IG5T+ODrbjzRDA5NUFu+eumTU7WvrHupL6N9249ARMuPyxYGhlCCyvs6yJ4+H0Z5XYWgD6qA4or6iiOgJq91arnk5Qp6XAWOL2fjU5GQEjNpeov6iQMFj1OAhcBAIeepf7V60QwaGElsDsjaAPgJGEP3btuAsB/6v/hDZXsrdCPvfIovNEE7833n3hxMhX9LpJs3eGeqBpGnzmjFZHPi9UrFomcBm66lHLTN0DbPdP6dyqmJcPqoIHJkJBVIq6E5r8oPxmdA/kXyxVQYeRUHCMO91QBmtvJzg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EoT2Z/xUjd5k1P2DiCSyDTWvB2BrS/A1SKUq6/DNs6vHenF+SztGTJr+Xroi/VYTNitrFmw17GRWmRrqknp9THoL6e1l0Eutvivc1Rrm8cmNGjtNAC6lMfztYNMdhNvuDft72bZWPLYqMDlRZo6jdapGq3IimkPJN+c0QMx0AX8QYgayKQ/7Aeg4NcEnvaDRv4hFcfmCi0A4c6teAr9ZttG+BA9V95wmvaRhdwUEVAxiB/tkPC0f128G+yyT/Ya0oWpThJj8NReesfZBDh3++fKrf00JyMZ2Wk9oezVasQj+f2y/+/fa17DeG9TtJbxSfI+pWM9KuTJ4NHK3ZPPGFw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 12 Apr 2024 15:30:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHai6GBZ8b+Nd1+T0SyR++yfNJA87FiLIoAgAF1zYCAAQgbgIAAGvcA
- Thread-topic: [PATCH v2 1/4] docs: add xen_ulong_t to the documented integers sizes/alignments
Hi Julien,
> On 12 Apr 2024, at 15:53, Julien Grall <julien.grall.oss@xxxxxxxxx> wrote:
>
>
>
> On Thu, 11 Apr 2024 at 18:08, Stefano Stabellini <sstabellini@xxxxxxxxxx>
> wrote:
> On Wed, 10 Apr 2024, Julien Grall wrote:
> > On Wed, 10 Apr 2024 at 19:47, Stefano Stabellini
> > <stefano.stabellini@xxxxxxx> wrote:
> > xen_ulong_t is widely used in public headers.
> >
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
> > ---
> >
> > Given that xen_ulong_t is used in public headers there could be a
> > better
> > place for documenting it but this was the most straightforward to add.
> > ---
> > docs/misra/C-language-toolchain.rst | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/docs/misra/C-language-toolchain.rst
> > b/docs/misra/C-language-toolchain.rst
> > index 5ddfe7bdbe..7a334260e6 100644
> > --- a/docs/misra/C-language-toolchain.rst
> > +++ b/docs/misra/C-language-toolchain.rst
> > @@ -531,6 +531,17 @@ A summary table of data types, sizes and
> > alignment is below:
> > - 64 bits
> > - x86_64, ARMv8-A AArch64, RV64, PPC64
> >
> > + * - xen_ulong_t
> > + - 32 bits
> > + - 32 bits
> > + - x86_32
> > +
> > + * - xen_ulong_t
> > + - 64 bits
> > + - 64 bits
> > + - x86_64, ARMv8-A AArch64, RV64, PPC64, ARMv8-A AArch32, ARMv8-R
> > + AArch32, ARMv7-A
> >
> >
> > We support neither ARMv8-R nor ARMv8-A Aarch32.
> >
> > I could possibly accept the latter because it works to. But the former is
> > so far misleading.
>
> Yes I think you are right. Moreover this document
> (C-language-toolchain.rst) is meant for the Xen build. While this patch
> is trying to document the types used in the public headers for the
> external-facing ABI.
>
> I'll move the information this patch is adding to a separate document,
> specific to the public headers. I will only add the architectures
> currently working: I'll add ARMv8-A Aarch32 because although it is
> unsupported it is interesting to know the size of xen_ulong_t for
> aarch32 in the public headers. I will remove ARMv8-R as it is not
> available upstream.
>
> Thinking a bit more. What about Armv9? Rather than listing each version,
> should we instead use ARMv7-A aarch32 and later, ARMv8-A aarch64 and later?
Definitely you are right here but as for Armv8-R, Armv9 is not something that
we explicitely support right now (even though it should work).
Cheers
Bertrand
|