[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v1 06/15] x86/p2m: guard altp2m code with CONFIG_VMX option
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- Date: Tue, 16 Apr 2024 10:03:09 -0700
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=tklengyel.com; spf=pass smtp.mailfrom=tamas@xxxxxxxxxxxxx; dmarc=pass header.from=<tamas@xxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1713287029; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=7Go4dEzn1Ajd6exfmxX0SEKoPMjpljLqVLm4QQhwmFo=; b=hpqusrcBgLLa12+sNbobk+SUSjTafDWaTofbaLdi8KeE8yX4Uk+oueA44tiLtaKYNTgwLzf71X7YxpOlQKnuId6fUqP10zMy6TCJSWGXI3yAqJp74KWiC8I4BfAEXs+107rj4unJRYDdb1p1UUWCtHaum1x9XCtB/UVeVMyDshw=
- Arc-seal: i=1; a=rsa-sha256; t=1713287029; cv=none; d=zohomail.com; s=zohoarc; b=W2/fh3WAHpzvisyJ1bKbJLyJDlMtM20FfdPzvfFXPpoGZ6Fwqt3dKzIyXJlvJDcXxWHVRCpM+8ccgJ1St6iHCwCZrxOC2LdCzXhyVhx16/iSUufn+7mWYBe+NsWRnWDbH9GCXh42JwiRTvJjrmZ9rJlQ0bVXTcZajaFoSzTQFrI=
- Cc: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 16 Apr 2024 17:04:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Apr 16, 2024 at 3:29 AM Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>
> On 16/04/2024 7:31 am, Sergiy Kibrik wrote:
> > Instead of using generic CONFIG_HVM option switch to a bit more specific
> > CONFIG_VMX option for altp2m support, as it depends on VMX. Also guard
> > altp2m routines, so that it can be disabled completely in the build.
> >
> > Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
>
> Altp2m is not VMX-specific. It's just no-one has wired it up on AMD, or
> accepted the long-outstanding ARM patchset where it was made to work.
>
> If you want to compile it, you probably want CONFIG_ALTP2M.
>
> However, it's not even x86 specific. See the uses in common/monitor.c
As Andrew said, it is not VMX specific so shouldn't be tied to that.
Adding a CONFIG_ALTP2M would be OK.
Tamas
|
