[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v1 06/15] x86/p2m: guard altp2m code with CONFIG_VMX option
- To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Sergiy Kibrik <sergiy_kibrik@xxxxxxxx>
- Date: Thu, 18 Apr 2024 13:47:37 +0300
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xDk5kIw2oYsCMB0+djCuWaLw+tKH6hMN4lLH0Oxfk/w=; b=KLvzFAw+/JZR96JGWdAy99s7dbN8Bz0G8fvBO+2ZN7ieGHR4Apigdk/w0zH6jIMp+TYUbbRiG7oa8KbyB9/s1fW/RmP8yqtQ4mR8bTfUlD0Qau+TH+QmmbmirMssRbC1ZIKlBfG5ocTttRCY2nUxWZEIIr66x/2r7rE87QPjVvJdBkVqXr65o1uknyP/J2EKgCwIvhF3WU7orGijewXVH86ZCz+60ReWUX/8y/k0FX1o3RuT12YtSP5dn9YuIcUypQF0J3qKGMhJPXjSWHHC76VDno1ETnoDqrMIpD0Y/Z1bz70OKOWnPW6q8z8Cjx/QaT0IQk7K/ddMQPgDNfWZbw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yi4ysmQqyxJWCQZYSWswvWq1c9tl+xndqDFJF1RTmVEZEc1gLaIyJ47EPyLAKHlyEgO6UfNsj19xE3C5u0aBbWua5dFGTY9L/EboNJeyUM8lyae1FSmU9+Pbf+YMl3ASFWc+bJUxKoznMirkO9hv7X1fJg+Tv5VdG/XlpzdpInWdvxDoTA06hZgGnSeJanq9i03H2265q4zjyu/fRntt+edyAjFX71BQsADdOvg2l2JnJRc1gbBuFIisAq7mkOn/1yq5o6BIMmcSL40A2bbkQG2Vw2LaZ1WgM1TlbF8qiB1XBbYJEURV0QF6vuCIxcruNJuDzGQTPyl291L9ZaR0ig==
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Thu, 18 Apr 2024 10:47:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
16.04.24 20:03, Tamas K Lengyel:
On Tue, Apr 16, 2024 at 3:29 AM Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
On 16/04/2024 7:31 am, Sergiy Kibrik wrote:
Instead of using generic CONFIG_HVM option switch to a bit more specific
CONFIG_VMX option for altp2m support, as it depends on VMX. Also guard
altp2m routines, so that it can be disabled completely in the build.
Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
Altp2m is not VMX-specific. It's just no-one has wired it up on AMD, or
accepted the long-outstanding ARM patchset where it was made to work.
If you want to compile it, you probably want CONFIG_ALTP2M.
However, it's not even x86 specific. See the uses in common/monitor.c
As Andrew said, it is not VMX specific so shouldn't be tied to that.
Adding a CONFIG_ALTP2M would be OK.
understood. I shall go with CONFIG_ALTP2M option then. Thanks for
clarification!
-Sergiy
|