Re: [PATCH v1] xen/riscv: improve check-extension() macro

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Mon, 2024-04-29 at 15:30 +0200, Jan Beulich wrote:
> On 26.04.2024 17:23, Oleksii Kurochko wrote:
> > Now, the check-extension() macro has 1 argument instead of 2.
> > This change helps to reduce redundancy around usage of extensions
> > name (in the case of the zbb extension, the name was used 3 times).
> > 
> > To implement this, a new variable was introduced:
> >   <extension name>-insn
> > which represents the instruction support that is being checked.
> > 
> > Additionally, zbb-insn is updated to use $(comma) instead of ",".
> 
> Which is merely just-in-case, I suppose, but not strictly necessary
> anymore?
Sorry for late reply, you are right, this is not strictly necessary
anymore.

~ Oleksii

> 
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Just as a remark: Tags want to be put in chronological order.
> 
> Jan