[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC KERNEL PATCH v6 2/3] xen/pvh: Setup gsi for passthrough device
- To: Juergen Gross <jgross@xxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Fri, 10 May 2024 08:42:32 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2/oSdE+eyGm1cwEYkGUybu0Kw1gWDAc+wgB0BtK8ZJk=; b=L2NrbiuO8tDg0qdINKci52V6h+R5dtoXzEY2k/bgYyAYpB51af6kz/fynA3l1u6i6CWHWKNgwehYh1ZnL1wkUF7+vxfdM9QIzGS79iWr3nh/gM9PgGYmipuKk+5q7e/a6fyg1hBhOk6ILYaPlGRbAvkUYzrRz25dVmvU4PyOdUe6LZYEu7o0fAqZO9aFHmZj9G9EcM3GDOccrZj+pderr94Ey0z/kQjXYpLmLzDAbS6O68bodz3Tptj+GFuRk8R/99vXhcCkYPErk1QztdG/8Fd5yYfrar7+Wlb0L3CJumJtiQkFbGF4Ps5ycuEHMmN2YGMAfvOZXWVgFQUo9qMb0A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q31kmu1URS2/jPZHUjbpUAL3YXK/GnC3dv4ylrh2jH8mOeC44gy4kk3gJkK6uDmC+qgrH9yxyA8XoHnzqrLPPSb30QQJtFbkKH+FxigWQIkfj5wZRUDix7OO2/JAbi5IjELuQB0cujLsdTCIGj1AioR+f3TcwLZmuKmfQbjl/+ADgAm6ofmc8xR/44wywqIOGheldKZJbaG+W7CF5BrDiGSRDGGdYT1Dld2mdZW+IW5N44OyNbhXucxvfulnLPWkZEFdqd2+T2CflhVUQLUxjmnBoP9UKsVrih0px3gEJFBBZIwWk7OuEzf3Siz6rsJn7UEaPJXOn5j7s1nl73hW/Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, "Rafael J . Wysocki" <rafael@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-pci@xxxxxxxxxxxxxxx" <linux-pci@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-acpi@xxxxxxxxxxxxxxx" <linux-acpi@xxxxxxxxxxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Fri, 10 May 2024 08:42:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHakgrNAUhcae4lxEaXCyVvErnSM7GQOM+AgACN+IA=
- Thread-topic: [RFC KERNEL PATCH v6 2/3] xen/pvh: Setup gsi for passthrough device
Hi,
On 2024/5/10 15:48, Juergen Gross wrote:
> On 19.04.24 05:36, Jiqian Chen wrote:
>> In PVH dom0, the gsis don't get registered, but the gsi of
>> a passthrough device must be configured for it to be able to be
>> mapped into a domU.
>>
>> When assign a device to passthrough, proactively setup the gsi
>> of the device during that process.
>>
>> Co-developed-by: Huang Rui <ray.huang@xxxxxxx>
>> Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
>> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>
> This patch is breaking the build.
>
> On Arm I get:
>
> In file included from
> /home/gross/korg/src/drivers/xen/xen-pciback/pci_stub.c:23:0:
> /home/gross/korg/src/include/xen/acpi.h: In function
> 'xen_acpi_sleep_register':
> /home/gross/korg/src/include/xen/acpi.h:67:3: error: 'acpi_suspend_lowlevel'
> undeclared (first use in this function); did you mean
> 'xen_acpi_suspend_lowlevel'?
> acpi_suspend_lowlevel = xen_acpi_suspend_lowlevel;
> ^~~~~~~~~~~~~~~~~~~~~
> xen_acpi_suspend_lowlevel
> /home/gross/korg/src/include/xen/acpi.h:67:3: note: each undeclared
> identifier is reported only once for each function it appears in
> make[6]: *** [/home/gross/korg/src/scripts/Makefile.build:244:
> drivers/xen/xen-pciback/pci_stub.o] Error 1
> make[5]: *** [/home/gross/korg/src/scripts/Makefile.build:485:
> drivers/xen/xen-pciback] Error 2
> make[4]: *** [/home/gross/korg/src/scripts/Makefile.build:485: drivers/xen]
> Error 2
Thanks for testing on Arm, it seems I should use macro "CONFIG_X86" to isolate
the modifications to this file.
>
> Additionally I'm seeing this warning on x86_64:
>
> /home/gross/korg/src/arch/x86/xen/enlighten_pvh.c:97:5: warning: no previous
> prototype for ‘xen_pvh_passthrough_gsi’ [-Wmissing-prototypes]
> int xen_pvh_passthrough_gsi(struct pci_dev *dev)
I think I need to add " #include <xen/acpi.h> " in file enlighten_pvh.c.
>
>
> Juergen
--
Best regards,
Jiqian Chen.
|
