[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC KERNEL PATCH v6 3/3] xen/privcmd: Add new syscall to get gsi from irq


  • To: Jürgen Groß <jgross@xxxxxxxx>
  • From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
  • Date: Fri, 10 May 2024 10:13:50 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fE1xWl7iYKuUfNNEOxMllWLYvD3ACCLq5DbAXgM4d+I=; b=lwPMk7g4shJq9CPQiwPkK1dE6WE2vbshSZt+37w1UkJ2W/7qdDIBifkQ1Phrb7FFi2Ks0r9w1Wh34y5kKFXVp1regreM/Uqig/vyFBW5reS8U1CCrQV46z5/3kH0JOsrQMktKctfQk40R0nLeSUXeMnyAtCEw9tuD+oUiL8P7StZtV8c+aj9nWrQOXr4vQEdFEHKW11EcI2WGshzDuhhayFOuFy6qO6U0y/jk7UBXtSSUvMLfj4ZT3YWiFroGhhoGA0vqO8CteEFW4npIHhqX7oDiVW4u6F0MVoUDXKVLtMInfDsriDpahWNZm/dxYlWdsuA31Bnr3hz52kgHpJbVw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SWnSJgCYVW65VrBuxTED7HnZOEdGgnvU7RmLEjpiBvIsDqOXix1Sgx3gUlfUHWQKIdDKlUfLrdWa5GuvvzyBPa+v12RceFE7uTxzv5REkS0IRdNy5qQk6u1XH1MCyMRq/rszg5xL9gWkOTqdcH8iVWSgL6cZJWR91yXgNbsLNeDLjP+Z5iTP+0mIwCoORaEBdw6GBdwwgrTws+XFhO97Hvd1jHwyfZmgo7fTFvofBm145c7p8UKT4rboQFx/rVb+oFy09KJq78wvIQPPz3yZ20bWSzkQkTXeZOtxUHIhlqk80IbEQxRHtTCL1GDwfRFyRWsRT161JZ/VaAHXp9XNMQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, "Rafael J . Wysocki" <rafael@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-pci@xxxxxxxxxxxxxxx" <linux-pci@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-acpi@xxxxxxxxxxxxxxx" <linux-acpi@xxxxxxxxxxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
  • Delivery-date: Fri, 10 May 2024 10:13:59 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHakgrPZQMiHHEzE0Gs/TUOGsHh17GQJ2yAgACnAgD//41hgIAAiXAA
  • Thread-topic: [RFC KERNEL PATCH v6 3/3] xen/privcmd: Add new syscall to get gsi from irq

On 2024/5/10 17:53, Jürgen Groß wrote:
> On 10.05.24 11:06, Chen, Jiqian wrote:
>> Hi,
>>
>> On 2024/5/10 14:46, Jürgen Groß wrote:
>>> On 19.04.24 05:36, Jiqian Chen wrote:
>>>> +
>>>> +    info->type = IRQT_PIRQ;
>> I am considering whether I need to use a new type(like IRQT_GSI) here to 
>> distinguish with IRQT_PIRQ, because function restore_pirqs will process all 
>> IRQT_PIRQ.
> 
> restore_pirqs() already considers gsi == 0 to be not GSI related. Isn't this
> enough?
No, it is not enough.
xen_pvh_add_gsi_irq_map adds the mapping of gsi and irq, but the value of gsi 
is not 0,
once restore_pirqs is called, it will do PHYSDEVOP_map_pirq for that gsi, but 
in pvh dom0, we shouldn't do PHYSDEVOP_map_pirq.

> 
> 
> Juergen

-- 
Best regards,
Jiqian Chen.

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.