[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 1/2] xen/arm: Add DT reserve map regions to bootinfo.reserved_mem
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 15 May 2024 10:05:21 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OaDAydz/Q82yXYNpdavomn0aM1mGqVxyXJ57CCbCVRQ=; b=EvpfcOfouGo59zgKlx0J0EyzlFRcfIYC/QGhnoU+ydL/5MlAYKUH0HYSFK+WnlpxnPG2uEKuyoB5ONPn7yOTtAG98JFZOeVdyPJTSYwBLBEE6IzmQTul0jA6fmiSXgNv0qP6OGQpH/JafMpm1mstmOvFtzwqZjxCHAghKnO2cE+MQyHHGBjqWfrNm+Mx4u977H+gIg5Podud6PoiHbBcL8zlcWIZWzu0+6bUjjp/mGswsaxJyoU4GHPALgPrGLImuyspX0rN59+dSlqL9yW0hcYI+Sur4V73ucmuJybQtN4tnvEKoGK3Yt+vrNjsG4DAN+dbxZ5OrZHpYYJ4z7JrmA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OaDAydz/Q82yXYNpdavomn0aM1mGqVxyXJ57CCbCVRQ=; b=aO9gLypaWLjxQx6SlNpbkwXRkaHKT8ukAVHX6WUpA4nI3rAz01Qq2uxMD4isoZYvgAXDD06T5P5Cz1WLg90jMwQK1tQ/NqMzbrQJ67Hrl+MfEmLPj8YiXA2cTonaSkUZYUn2FS/eShLolxamxQVDSXFyqsojZaeLopuOroAIicDqrNlx4iT6oIn7rO1Alju8zMF8xYfLOeTumoUpdXj1Op/fS2uWpsrnxcZgcLNA61l4xep/unciFJmv4qyQDVVFBpirTRZBoUoNWuxMdMd0m39K1rnF4jS/4bUW2kyQr3PIKzESuF400sWRgeYSjn0xye9JgaSFnHYmq4doYG1tJA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=SFUm932Tz4AnUD9SF28nLDFabLNOc2t9gmBFYgTtGS075ZdKZEIJGh7xwZhc5YkvYBPBIlLst4crLUEWJl9DJPIxVmudawQatMJZ/q2fRzmB5Li7fBfo59+6QJEwGEXs7SA7+lUNyGaz/0COF0sqdP4D78/e2Vka1RN/jOZKs/Qos5R0gc5Bz1hP80iTZPAiocC+r8vEu197XSxn8ImFvzwqhvfRV5UbaVe0CPCtbvE9YEktk4ElXsWUYUQBbwz5JR3duiCWXFxU/Rl7/qN6UztWbMLJEXSfzsQd8k0rxAcmVmUPtMN+IwaVI9ZMPdaG+WZgU38pchsEncHCWloA7g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=apFVMNhwC/MqDi1uTPrg4BNNiTeGnWP3cstnkYmzT7oPuP+38WGZaLagqRuZLpn2a1leve9bwtMXOX7hchVk3FP2eSqUTOiC7WfzQYg1SH6DwUeIJUXubrP9Acc+y/TF98xtRykm6G26WSsK7AxycsW9+PC82RiCUFfdoHa45oQdimQqWaQZwxUQJKs7OjU4NgUS795KKx8Bj+TYuNR+0LzZ6uq045LXbc3KEwKOTCBCsdQU94ney9fIPL02wpiYIF+NXcajtwjU5vvJTYJn5bNETqOCBWv6K2FkxKkhDqM2MyRl2GotZc/VK7TaPOzlCT1FztiENn0Y8Gw1jhgGHw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 15 May 2024 10:06:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHalxIi36RR5t8uSEeoUslJ6d4QpLGV0j4AgACnKQCAAN2CAIAA2a+A
- Thread-topic: [RFC PATCH 1/2] xen/arm: Add DT reserve map regions to bootinfo.reserved_mem
> On 14 May 2024, at 22:06, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi,
>
> On 14/05/2024 08:53, Luca Fancellu wrote:
>> Hi Julien,
>> Thanks for having a look on the patch,
>>> On 13 May 2024, at 22:54, Julien Grall <julien@xxxxxxx> wrote:
>>>
>>> Hi Luca,
>>>
>>> On 25/04/2024 14:11, Luca Fancellu wrote:
>>>> Currently the code is listing device tree reserve map regions
>>>> as reserved memory for Xen, but they are not added into
>>>> bootinfo.reserved_mem and they are fetched in multiple places
>>>> using the same code sequence, causing duplication. Fix this
>>>> by adding them to the bootinfo.reserved_mem at early stage.
>>>
>>> Do we have enough space in bootinfo.reserved_mem for them?
>> So we have 255 banks, in my experience I would say I’ve never saw too many
>> reserved regions
>> in the DT, maybe a couple, but I’ve always had to deal with embedded
>> platforms.
>> I’ve tested this one with ADLINK AVA board, n1sdp, Juno, raspberry pi, qemu,
>> fvp.
>> In your experience, have you seen any numbers that could be concerning?
> I know in the past we had to bump the memory banks a few times. But as you
> tested on a few platforms, I think we should be ok.
>
> It would be best if this patch goes sooner than later to allow wider testing
> before we release 4.19.
>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
Yes it would make sense, this patch makes sense on its own, would you/anyone
commit it separately while I work on the second
patch?
|
