Re: [RFC PATCH v2 4/5] docs/man: document VIF vlan keyword

[Leigh Brown <leigh@xxxxxxxxxxxxx>]

Hi Jason,

On 2024-05-15 01:57, Jason Andryuk wrote:
> On Wed, May 8, 2024 at 5:39 PM Leigh Brown <leigh@xxxxxxxxxxxxx> wrote:
> > Document the new `vlan' keyword in xl-network-configuration(5).
> >
> > Signed-off-by: Leigh Brown <leigh@xxxxxxxxxxxxx>
> Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
>
> One nit below
>
> > ---
> >  docs/man/xl-network-configuration.5.pod.in | 38 
> > ++++++++++++++++++++++
> >  1 file changed, 38 insertions(+)
> >
> > diff --git a/docs/man/xl-network-configuration.5.pod.in 
> > b/docs/man/xl-network-configuration.5.pod.in
> > index f3e379bcf8..c35c0922b3 100644
> > --- a/docs/man/xl-network-configuration.5.pod.in
> > +++ b/docs/man/xl-network-configuration.5.pod.in
> > @@ -259,6 +259,44 @@ Specifies the MTU (i.e. the maximum size of an IP 
> > payload, exclusing headers). T
> > +Note, one VLAN ID must be marked as the PVID. In the case of a vlan
> > +specification consisting of a single VLAN ID (e.g. C<vlan=10>), the 
> > B<p> suffix
> > +may be omitted. Specifying more than one untagged VLAN ID is an 
> > advanced
> > +configuration - use with caution.
> > +
> > +For example:
> > +
> > +        'vlan=10' -- meaning a single VLAN that is the PVID.
> > +       'vlan=10p/20' -- VLAN 10 is the PVID and VLAN 20 is tagged.
> > +       'vlan=10p/100+10x4' -- VLANs 10, 100, 110, 120, 130, 140, 150.
> Indent mismatch between 7 and 8 spaces.
FWIW I will sort that too :-)

> > +
> >  =head2 trusted / untrusted
> >
> >  An advisory setting for the frontend driver on whether the backend 
> > should be
> > --
> > 2.39.2
Regards,

Leigh.